Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169801
Summary: | Review Request: perl-Net-IP-CMatch - Efficiently match IP addresses against IP ranges with C | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> | ||||
Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-extras-list | ||||
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-10-19 14:53:01 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Orion Poplawski
2005-10-03 19:53:29 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) and in mock for rawhide (i386) - BR's mostly OK - no libraries, locales, subpackages or pkgconfigs to worry about - not relocatable - no duplicate files - no file permission issues - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop entry needed - no scriptlets Needswork: - package should own directory %{perl_vendorarch}/Net since it's not owned by any of its dependencies Nitpick: - perl is part of the minimal buildroot and hence the explicit BR: perl is not needed Suggestions: - http://search.cpan.org/dist/Net-IP-CMatch/ would be a more stable URL to use since it won't change if there is a new upstream version and the package is updated - using %{version} instead of hardcoding the version number in the Source0 URL would mean less to change and less chance of errors if there is a new upstream version and the package is updated - the compiler optimization flags setting could be simplified to: %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags} - the "Changes" file could be included as %doc Created attachment 120127 [details]
Patch addressing review issues
(In reply to comment #3) > Applied. Thanks! > > http://www.cora.nwra.com/~orion/fedora/perl-Net-IP-CMatch-0.02-2.src.rpm Approved. Build on devel completed Package Change Request ====================== Package Name: perl-Net-IP-CMatch New Branches: epel7 Owners: orion InitialCC: Git done (by process-git-requests). |