Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170372
Summary: | Review Request: moodle: A Course Management System | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, pertusus, sundaram |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://moodle.org/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-13 07:03:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Ignacio Vazquez-Abrams
2005-10-11 02:14:37 UTC
Just one comment, I think there should be a Requires: webserver And a question, why is there: %define __perl_requires %{nil} %define __perl_provides %{nil} Maybe a comment could explain it? Re the webserver bit, moodle requires php-gd which eventually pulls in httpd. As for the __perl_* bit, I've added a note. Updated. http://www.joomla.com/ seems to be a upstream developer fork. Might want to look into that Joomla seems to be a fork of Mambo. I don't see a link between Mambo and Moodle, other than vaguely playing in the same space. Moodle is targeted almost exclusively at the educational space. You are right. I was confusing Mambo with Moodle. Never mind - GPL license good, but need to include a copy of the text - code not content - proper chkconfig usage - consistent macro usage rpmlint shows a lot of zero length files, mostly .sql. This should be harmless. Ignoring those still leaves us with: E: moodle non-standard-uid /var/www/moodle/data apache E: moodle non-standard-gid /var/www/moodle/data apache E: moodle non-executable-script /var/www/moodle/web/admin/process_email.php 0644 W: moodle non-conffile-in-etc /etc/httpd/conf.d/moodle.conf E: moodle non-executable-script /var/www/moodle/web/mod/chat/chatd.php 0644 E: moodle non-executable-script /var/www/moodle/web/mod/wiki/ewiki/fragments/mkhuge 0644 E: moodle htaccess-file /var/www/moodle/web/auth/shibboleth/.htaccess W: moodle wrong-file-end-of-line-encoding /usr/share/doc/moodle-1.5.2/README.txt W: moodle non-conffile-in-etc /etc/cron.d/moodle E: moodle non-executable-script /var/www/moodle/web/lib/editor/plugins/SpellChecker/spell-check-logic.cgi 0644 E: moodle wrong-script-end-of-line-encoding /var/www/moodle/web/lib/editor/plugins/SpellChecker/spell-check-logic.cgi E: moodle no-chkconfig-line /etc/rc.d/init.d/moodle None of the localization pacakges have docs, and a few have zero length php file. Updated. I put the editor's spell check plugin into a separate package disabled by default since it needs Text::Aspell. http://fedora.ivazquez.net/files/extras/moodle.spec http://fedora.ivazquez.net/files/extras/moodle-1.5.3-1.src.rpm (In reply to comment #6) > E: moodle non-standard-uid /var/www/moodle/data apache > E: moodle non-standard-gid /var/www/moodle/data apache Moodle needs to store data on the filesystem. > E: moodle non-executable-script /var/www/moodle/web/admin/process_email.php 0644 Just a file with a shebang line, no biggie. > E: moodle non-executable-script /var/www/moodle/web/mod/chat/chatd.php 0644 Interesting, a chat daemon written in PHP. I'm not sure how changing this will impact Moodle, although I feel it can be done easily enough once the package has been imported. > E: moodle non-executable-script /var/www/moodle/web/mod/wiki/ewiki/fragments/mkhuge 0644 I could easily enough remove this, I suppose. Your call. > E: moodle htaccess-file /var/www/moodle/web/auth/shibboleth/.htaccess Needed for shibboleth auth, AFAICT. > W: moodle non-conffile-in-etc /etc/cron.d/moodle > None of the localization pacakges have docs, and a few have zero length php file. There are no non-English docs AFAICS. And I'm relutant to remove the zero-length files as I don't know how it will affect Moodle. (In reply to comment #7) > (In reply to comment #6) > > E: moodle non-standard-uid /var/www/moodle/data apache > > E: moodle non-standard-gid /var/www/moodle/data apache > > Moodle needs to store data on the filesystem. > OK, ignoring. > > E: moodle non-executable-script /var/www/moodle/web/admin/process_email.php 0644 > > Just a file with a shebang line, no biggie. > > > E: moodle non-executable-script /var/www/moodle/web/mod/chat/chatd.php 0644 > > Interesting, a chat daemon written in PHP. I'm not sure how changing this will > impact Moodle, although I feel it can be done easily enough once the package has > been imported. > OK, ignoring, as long as it works without execute bit. > > E: moodle non-executable-script > /var/www/moodle/web/mod/wiki/ewiki/fragments/mkhuge 0644 > > I could easily enough remove this, I suppose. Your call. > Keep. It's of limited use, but no harm done in keeping it. > > E: moodle htaccess-file /var/www/moodle/web/auth/shibboleth/.htaccess > > Needed for shibboleth auth, AFAICT. OK. > > > W: moodle non-conffile-in-etc /etc/cron.d/moodle > > > None of the localization pacakges have docs, and a few have zero length php file. > > There are no non-English docs AFAICS. And I'm relutant to remove the zero-length > files as I don't know how it will affect Moodle. OK. Ignoring all those and rpmlint doesn't like the 0755 perms on moodle init scripe but matches those on my system. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - locales handled with the sub packages - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - works, imported sucessfully into mysql APPROVED Built for FC4 and devel. |