Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1703846

Summary: gcc-python-plugin 0.17-4.fc31 FTBFS with Python 3.8
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: gcc-python-pluginAssignee: Orphan Owner <extras-orphan>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, dmalcolm
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-25 22:41:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1750908, 1750909, 1686977    
Attachments:
Description Flags
Full log from Copr
none
Full build log none

Description Miro Hrončok 2019-04-28 19:12:01 UTC
Created attachment 1559681 [details]
Full log from Copr

/builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/tests/plugin/syntax-error: FAIL

returncode: 1
  compiling: gcc -c -fno-diagnostics-show-caret -ftrack-macro-expansion=0 -o /builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/tests/plugin/syntax-error/output.o -fplugin=/builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/python3.so -fplugin-arg-python3-script=/builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/tests/plugin/syntax-error/script.py -fsigned-char /builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/tests/plugin/syntax-error/input.c
Stdout:

Stderr:
      File "/builddir/build/BUILD/gcc-python-plugin-0.17/building-for-python3/tests/plugin/syntax-error/script.py", line 18
        Test handling of Python syntax errors.
             ^
    SyntaxError: invalid syntax--- Expected stderr (after cleaning)
+++ Actual stderr (after cleaning)
@@ -1,4 +1,4 @@
   File "tests/plugin/syntax-error/script.py", line 18
     Test handling of Python syntax errors.
-                ^
+         ^
 SyntaxError: invalid syntax



I believe the whitespace amount here changed and the test fails because of that. Full log attached.

Comment 1 Miro Hrončok 2019-07-09 16:07:39 UTC
Dave?

Comment 2 Charalampos Stratakis 2019-07-24 14:15:33 UTC
After removing the bad test I get another error with the latest version of Python 3.8:

'"/usr/lib/gcc/x86gcc-python-wrapper.c:188:1: error: converting to non-pointer type 'long int' from NULL [-Werror=conversion-null]
  188 | };
      | ^
autogenerated-callgraph.c:112:1: error: designator order for field '_typeobject::tp_getattr' does not match declaration order in 'PyTypeObject' {aka '_typeobject'}
  112 | };
      | ^
autogenerated-callgraph.c:198:1: error: designator order for field '_typeobject::tp_getattr' does not match declaration order in 'PyTypeObject' {aka '_typeobject'}
  198 | };
      | ^
make: *** [Makefile:168: autogenerated-callgraph.o] Error 1
make: *** Waiting for unfinished jobs....
cc1plus: all warnings being treated as errors
make: *** [Makefile:168: gcc-python-wrapper.o] Error 1
autogenerated-cfg.c:164:1: error: designator order for field '_typeobject::tp_getattr' does not match declaration order in 'PyTypeObject' {aka '_typeobject'}
  164 | };
      | ^
autogenerated-cfg.c:265:1: error: designator order for field '_typeobject::tp_getattr' does not match declaration order in 'PyTypeObject' {aka '_typeobject'}
  265 | };
      | ^
autogenerated-cfg.c:362:1: error: designator order for field '_typeobject::tp_getattr' does not match declaration order in 'PyTypeObject' {aka '_typeobject'}
  362 | };
      | ^
make: *** [Makefile:168: autogenerated-cfg.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.8wVRMu (%build)
    Macro expanded in comment on line 17: %{?dist}

Comment 3 Charalampos Stratakis 2019-07-24 14:17:46 UTC
Created attachment 1593151 [details]
Full build log

Attaching the latest full build log as well

Comment 4 Miro Hrončok 2019-07-24 14:38:01 UTC
Might that be related to: In Python 3.8, the reserved "tp_print" slot was changed from a function pointer to a number, `Py_ssize_t tp_vectorcall_offset`.

Comment 5 Ben Cotton 2019-08-13 17:09:14 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 6 Ben Cotton 2019-08-13 18:56:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 7 Miro Hrončok 2019-08-14 22:24:57 UTC
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build

Comment 8 Miro Hrončok 2019-08-21 16:35:44 UTC
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

Comment 9 Miro Hrončok 2019-08-21 17:29:40 UTC
(Python 3.8 has landed in the rawhide buildroot.)

Comment 10 Miro Hrončok 2019-10-25 22:41:47 UTC
Automation has figured out the package is retired in rawhide.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement

Comment 11 Dave Malcolm 2021-06-22 16:35:31 UTC
Closing out needinfo flag