Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170492
Summary: | Review Request: qucs - Circuit simulator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eric Tanguy <eric.tanguy> | ||||||
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | alain.portal, gauret, rc040203 | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
URL: | http://qucs.sourceforge.net/ | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2005-10-21 22:21:49 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 163779 | ||||||||
Attachments: |
|
Description
Eric Tanguy
2005-10-12 10:33:35 UTC
Sorry, I can't sponsor you. Some improvements: Put the full download url in Source0, i.e. Source0 http://dl.sf.net/qucs/%{name}-%{version}.tar.gz In %changelog, remove ".fc4" in "0.0.7-5.fc4" to make rpmlint happy Build fine in mock In %install section, add rm -rf $RPM_BUILD_ROOT before make install Suggestion for the desktop file: desktop-file-install --vendor fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ --add-category "Engineering" \ --add-category "Electronics" \ --add-category "X-Fedora" \ %{SOURCE1} I think you should remove the "Categories" line in the desktop file, this isn't a Gnome based application. Comment #1 : Ok it will be done quickly Comment #2 : your suggestion about desktop file doesn't seem to work + desktop-file-install --vendor fedora --dir /var/tmp/qucs-0.0.7-5-root-tanguy/usr/share/applications --add-category Engineering ' ' Error on file " ": Failed to open file ' ': No such file or directory erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.25083 (%install) Work for me. I suspect you copy/paste from the bugzilla html page. Don't do this but edit by hand. I often meet problems about caracters set or related when I copy/paste examples of C source code or shell script. Ok you're right. Thanks. Now all it's ok and the files are uploaded. I still need a complete review and a sponsor. I'll do the sponsoring, but first, there is a couple of improvements to do : * Desktop file: the Categories tag should contain "Application" (wiki: PackagingGuidelines#desktop) Since your desktop file is in a separate source, you could just add this line to it : Categories=Application;Electronics;Engineering; and only use "--add-category X-Fedora" with desktop-file-install in the spec file (since this category is Fedora-specific, I would leave it in the spec file, but you can add it to the desktop file too) Minor : * use %setup -q in %prep, to cut off the untarring output. I did the improvements asked and uploaded the files. Do i need to increase the release number in spec file ? Increasing the release tag makes it easier to know which version has been approved, so please do that next time. Review for release 5: * RPM name is OK * Source qucs-0.0.7.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of qucs looks OK * File list of qucs looks OK * Works fine APPROVED Follow the steps to become an official contributor (http://fedoraproject.org/wiki/Extras/Contributors) and I'll sponsor you. VETO Package does not acknowledge RPM_OPT_FLAGS Pushing package back to FE-REVIEW. Created attachment 120112 [details]
Proposed spec changes to make package RPM_OPT_FLAGS aware
Created attachment 120113 [details]
Hacks to make configure script RPM_OPT_FLAGS aware
The origin of this problem is a broken configure script.
This patch is supposed to fix bring this configure script into usable shape.
Thanks for the patches. I also contact the developer and he put a patch in the cvs version. It will be all right on the next release. Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs-0.0.7-6.src.rpm I don't know if the new package have to be approved one more time ? New patched version for x86_64 arch Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs-0.0.7-7.src.rpm Looks OK, approving and closing bug (release 7 is already on the servers) Changed summary for tracking purposes. |