Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170504
Summary: | Review Request: makebootfat - Utility for creation bootable FAT disk | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dmitry Butskoy <dmitry> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://advancemame.sourceforge.net/doc-makebootfat.html | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-26 12:07:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Dmitry Butskoy
2005-10-12 14:09:31 UTC
- rpmlint says: E: makebootfat only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Probably a good idea, these are mbrs and such, not shared objects and not architecture dependent. Move this. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file It would be a good idea to show upstream the doc you wrote. > There are only non binary files in /usr/lib so they should be in /usr/share.
I'm not a x86 guru, but "file ldlinux.bss" say "x86 boot sector", "mbrfat.bin"
has a source "mbrfat.asm" which has x86 commends...
Are you sure these two files are architecture independent?
Perhaps we even should specify ExclusiveArch tag...
ping :) ? > Perhaps we even should specify ExclusiveArch tag...
Assume not, IMHO makebootfat executable can be run on any arch, just the result
(a disk image) seems to be x86-dependent.
OK, after reading the FHS I see that /usr/lib is the place for "internal binaries". A boot sector and an executable qualify. Note that under 64 bit these will appear under /usr/lib64, which is misleading. You may want to force /usr/lib As per comment 1, APPROVED. > Note that under 64 bit these will appear under /usr/lib64
Yep...
I think it would be better to behave like grub package, i.e. place these
x86-specific files under /usr/share/makebootfat/x86/* . IMHO it is more correct,
because under /usr/lib we should place some HOST-specific internal binaries, but
actually these two files are TARGET-specific...
(In reply to comment #6) > I think it would be better to behave like grub package, i.e. place these > x86-specific files under /usr/share/makebootfat/x86/* . IMHO it is more correct, > because under /usr/lib we should place some HOST-specific internal binaries, but > actually these two files are TARGET-specific... OK, doing it like grub makes sense in that respect. Do it that way, and tell upstream about this discussion about where to put these files, if you would please. APPROVED |