Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170506
Summary: | Review Request: grepmail | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
Component: | Package Review | Assignee: | Orion Poplawski <orion> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://grepmail.sourceforge.net/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-12 16:10:40 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 170507 | ||
Bug Blocks: | 163779 |
Description
Paul Howarth
2005-10-12 14:22:40 UTC
- md5sums match - builds clean - rpmlint silent - License checks out Minor: - remove the top comments. We know it's an application. Approved (In reply to comment #1) > - md5sums match > - builds clean > - rpmlint silent > - License checks out > > > Minor: > > - remove the top comments. We know it's an application. Will do; 'twas just a note to potential reviewers... Build on target development succeeded. Just a comment: %{_bindir}/find ... is pretty much free of sense. %_bindir is a user input parameter to rpmbuild, not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants). Try rpmbuild --define '_bindir /tmp' to experience the difference. I strongly recommend to use find or /usr/bin/find instead. (In reply to comment #4) > Just a comment: > %{_bindir}/find ... > > is pretty much free of sense. %_bindir is a user input parameter to rpmbuild, > not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants). Is this distinction described somewhere? > Try rpmbuild --define '_bindir /tmp' to experience the difference. Both %_bindir and %__chmod are defined in /usr/lib/rpm/macros and can be redefined in the same way on the command-line. I always believed that the macros were there to provide distribution-portability rather than being "user input parameters". > I strongly recommend to use find or /usr/bin/find instead. I see what you're getting at here, in that redefining %_bindir so that the binaries are installed in a different place breaks the build when it expects to find things in the same place. I'd rather not use plain "find" because that breaks reproducability of builds if someone has a different/broken version of find earlier in their PATH, so /usr/bin/find looks better to me. But it does make the assumption that %_bindir was set to /usr/bin when the distribution's "find" package was built, which may not be true on all distributions (not that any of this matters for Fedora Extras). Having said that, similar assumptions are made for programs in /bin, /sbin etc., which don't have corresponding macros defined for them. Ideally I suppose it would be better if there were additional macros defined such as %__find etc., but it's a bit late for that now. I'll probably change it to /usr/bin/find (In reply to comment #5) > (In reply to comment #4) > > Just a comment: > > %{_bindir}/find ... > > > > is pretty much free of sense. %_bindir is a user input parameter to rpmbuild, > > not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants). > > Is this distinction described somewhere? Rhethorical question: Is there any official documentation on rpm? Not that I am aware about. Only that "%_bindir" etc. are documented as "configure macros" in /usr/lib/rpm/macros, which means they are meant to be configuration input to be passed to a package, and do not denote a system feature (such as presence of /usr/bin/find, or %{__chmod}). Also, it's common practice for many years that users override the "autoconf" macros for various purposes. %_bindir/find requires you to use "BuildRequires: %_bindir/find" which unnecessarily prohibits users wanting to rebuild your rpm with a different _bindir. > Both %_bindir and %__chmod are defined in /usr/lib/rpm/macros and can be > redefined in the same way on the command-line. True, but note that these %__XXX macros use hardcoded directories, such as /usr/bin and do not use %_bindir. IMO, this is yet another strong indication for your usage to be incorrect. However probably only Jeff would be able to give a confirmative answer. |