Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1706027

Summary: python-uranium FTBFS with python 3.8
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-uraniumAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, python-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-04 07:35:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    
Attachments:
Description Flags
Full log from Copr none

Description Miro Hrončok 2019-05-03 12:11:08 UTC 
Created attachment 1562351 [details]
Full log from Copr

python-uranium 4.0.0-2.fc31 fails to build with Python 3.8 (in copr), but builds fine with 3.7 (in koji):

=================================== FAILURES ===================================
_________________________ test_getUsedSettings[data1] __________________________

data = {'code': '"x"', 'variables': ['x']}

    @pytest.mark.parametrize("data", test_getUsedSettings_data)
    def test_getUsedSettings(data):
        function = SettingFunction(data["code"])
        answer = function.getUsedSettingKeys()
>       assert len(answer) == len(data["variables"])
E       assert 0 == 1
E         -0
E         +1

tests/Settings/TestSettingFunction.py:141: AssertionError
_________________________ test_getUsedSettings[data7] __________________________

data = {'code': "sqrt('x')", 'variables': ['sqrt', 'x']}

    @pytest.mark.parametrize("data", test_getUsedSettings_data)
    def test_getUsedSettings(data):
        function = SettingFunction(data["code"])
        answer = function.getUsedSettingKeys()
>       assert len(answer) == len(data["variables"])
E       assert 1 == 2
E         -1
E         +2

tests/Settings/TestSettingFunction.py:141: AssertionError


Full log attached.
Comment 1 Miro Hrončok 2019-07-08 15:14:19 UTC 
From 4.1.0:

_________________________ test_getUsedSettings[data1] __________________________

data = {'code': '"x"', 'variables': ['x']}

    @pytest.mark.parametrize("data", test_getUsedSettings_data)
    def test_getUsedSettings(data):
        function = SettingFunction(data["code"])
        answer = function.getUsedSettingKeys()
>       assert len(answer) == len(data["variables"])
E       assert 0 == 1
E         -0
E         +1

tests/Settings/TestSettingFunction.py:141: AssertionError
_________________________ test_getUsedSettings[data7] __________________________

data = {'code': "sqrt('x')", 'variables': ['sqrt', 'x']}

    @pytest.mark.parametrize("data", test_getUsedSettings_data)
    def test_getUsedSettings(data):
        function = SettingFunction(data["code"])
        answer = function.getUsedSettingKeys()
>       assert len(answer) == len(data["variables"])
E       assert 1 == 2
E         -1
E         +2

tests/Settings/TestSettingFunction.py:141: AssertionError
Comment 2 Miro Hrončok 2019-07-08 15:16:23 UTC 
Reported upstream: https://github.com/Ultimaker/Uranium/issues/498
Comment 3 Miro Hrončok 2019-07-10 10:36:19 UTC 
I have a patch (posted to the upstream issue). Built the package in copr with it, will commit it during next 3.8 rebuilds if uranium is not updated until then.
Comment 4 Miro Hrončok 2019-08-02 10:47:30 UTC 
https://src.fedoraproject.org/rpms/python-uranium/pull-request/6