Bug 171334

nsd 2.3.2 was released today. I've upgraded the rpms and spec files.
- upgraded to 2.3.2
- no longer run chkconfig upon install in the spec file (FE policy)
- change nsd.init to not run on install (FE policy)

ftp://ftp.xelerance.com/nsd/binaries/fedora/4/nsd.spec
ftp://ftp.xelerance.com/nsd/binaries/fedora/4/nsd-2.3.2-1.src.rpm

binaries for fc3 (intel) and fc4 (intel, x86_64) are available as yum repository
at ftp://ftp.xelerance.com/nsd/binaries/fedora

There were some minor changes I made to your spec:

- used a %{?dist} tag (not mandatory, but good practice, IMHO)
- corrected Source path
(http://open.nlnetlabs.nl/downloads/nsd/%{name}-%{version}.tar.gz)
- moved rm -rf %{buildroot} from %prep to %install
- owned %dir %{_sysconfdir}/nsd/
- %{_mandir}/*/* doesn't need to be %doc, anything in %{_mandir} is %doc
automagically.

I'm going to attach the revised spec, I did the review off that spec file. Also,
note that 2.3.3 is out. You might want to update to that rev before committing.

Good:

- rpmlint checks return:
E: nsd non-executable-script /etc/nsd/nsdc.conf 0644
E: nsd postin-without-chkconfig /etc/rc.d/init.d/nsd

The nsdc.conf file has #!/bin/sh as its first line, but it's not a script (or
rather, its a shell script that does nothing but define variables). Safe to
ignore. The postin-without-chkconfig is also safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (BSD-like) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED (assuming that you use my spec file changes).

Created attachment 122112 [details]
updated spec file

I have incorporated your spec file changes.
nsd-2.3.2 and 2.3.3 fail to start properly when compiled with --enable-checking

I have a patch from the developers, but that still did not fix the issue. I left
their patch in but left out --enable-checking for now. In that configuration,
the nsd rpm is stable (and we're running it on our primary nameserver)

I've updated the rpm and spec file, and will commmit to FE when the access has
been created.

ftp://ftp.xelerance.com/nsd/binaries/fedora/4/SRPMS/nsd.spec
ftp://ftp.xelerance.com/nsd/binaries/fedora/4/SRPMS/nsd-2.3.3-2.src.rpm

Thanks!

Paul

Package Change Request
======================
Package Name: nsd
New Branches: epel7
Owners: pwouters

Git done (by process-git-requests).