Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171565
Summary: | Review Request: drgeo | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eric Tanguy <eric.tanguy> |
Component: | Package Review | Assignee: | Gérard Milmeister <gemi> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.ofset.org/drgeo | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-25 04:16:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Eric Tanguy
2005-10-23 10:28:06 UTC
Spec File: * Url: http://www.ofset.org/drgeo * %description: "is a interactive" -> "is an interactive" "figure" -> "figures" * BuildRequires: why include gnome-libs-devel, which is for gnome 1.4? * "%configure" suffices no need for "--prefix" * I think "rm" and "make" can (should?) be used instead of the macros * A litte post-processing of the .desktop file in %install: desktop-file-install \ --delete-original \ --vendor=fedora \ --add-category X-Fedora \ --dir %{buildroot}%{_datadir}/applications \ %{buildroot}%{_datadir}/applications/drgeo.desktop Of course, BuildRequires: desktop-file-utils * .desktop file sets icon to gnome-drgenius.png which does not exist. Suggest copying drgeo.png and setting "Icon: drgeo.png" (why is this commented out?) * Since there is no html documentation, consider patching the source to remove the "Contents" menu and button, and notifying upstream to correct this. * The texmacs files should go to %{_datadir}/TeXmacs/plugins/drgeo * update changelog (In reply to comment #1) > Spec File: > * Url: http://www.ofset.org/drgeo Done > * %description: "is a interactive" -> "is an interactive" > "figure" -> "figures" Done > * BuildRequires: why include gnome-libs-devel, which is for gnome 1.4? > * "%configure" suffices no need for "--prefix" Done > * I think "rm" and "make" can (should?) be used instead of the macros Done > * A litte post-processing of the .desktop file in %install: > desktop-file-install \ > --delete-original \ > --vendor=fedora \ > --add-category X-Fedora \ > --dir %{buildroot}%{_datadir}/applications \ > %{buildroot}%{_datadir}/applications/drgeo.desktop > Of course, BuildRequires: desktop-file-utils Done > * .desktop file sets icon to gnome-drgenius.png which does not exist. > Suggest copying drgeo.png and setting "Icon: drgeo.png" > (why is this commented out?) Done > * Since there is no html documentation, consider patching the source > to remove the "Contents" menu and button, and notifying upstream > to correct this. Ok I notified it upstream but i know only few about programming and i don't how to patch this ... > * The texmacs files should go to %{_datadir}/TeXmacs/plugins/drgeo Done > * update changelog Done > > Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-1.1.0-2.src.rpm * replace the remaining %{__rm} and %{__install} by rm and install * in the changelog you used 1.0.1 instead of 1.1.0 Make these small fixes and everything is ok. APPROVED (In reply to comment #3) > * replace the remaining %{__rm} and %{__install} by rm and install Why? In what way does this improve the package? This is largely a cosmetic issue but if anything I would say that using the macros was better, since they expand to fully-qualified pathnames and hence don't make the result of the build dependent on the value of the building user's PATH setting. |