Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1715936
Summary: | Review Request: bodhi3 - The bodhi3 client for Fedora 29 and 30 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Randy Barlow <rbarlow> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mhroncok, package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-06-12 00:45:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Randy Barlow
2019-05-31 17:07:18 UTC
The %descriptions needs to say that this is a compat package and explain when it should be used (and that it cannot be used with Fedora infra now). %{__install} → install (applies to the normal bodhi spec too). - builds and installs OK in mock - not latest version, but that's expected - package name is OK (follows https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple). Package is APPROVED. Please update the %descriptions when importing. I consider the following three lines suspicious: %{?python_provide:%python_provide python3-bodhi} %{?python_provide:%python_provide python3-bodhi-client} Requires: python3-bodhi == %{version}-%{release} (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bodhi3 I've adjusted the main Bodhi package to use install instead of the install macro here: https://src.fedoraproject.org/rpms/bodhi/c/66783a1c7f5dc1d3c01671ef1ae5557147fe8766?branch=master And here are commits I made to the bodhi3 package to address feedback from both of you (let me know if you would like further improvements, or if I missed anything): https://src.fedoraproject.org/rpms/bodhi3/c/9bc0d164f6552d01799483c539c5c1490925ce50?branch=f30 https://src.fedoraproject.org/rpms/bodhi3/c/fbb83784385cc6045b7b7536131e503e639845a7?branch=f30 https://src.fedoraproject.org/rpms/bodhi3/c/d5aa252633a31ab204df0b5fee65b4d9d3733ddc?branch=f30 I don't intend to make a rawhide build, so I haven't made any commits on master. I'm not tooooootally sure how retiring works, so I'm making myself a TODO to retire it after the f29 and f30 updates that have this package go stable, just so I can be sure nothing funny happens (i.e., I want to make sure there are builds tagged for stable in the stable releases first, just in case the releng retirement script blocks f29/30 if it detects there aren't builds there.) I will also put this in the same updates that introduce Bodhi 4 so they go out atomically. I just noticed something that I hadn't considered before - the F29 package still has Python 2 (but F30 does not). F29 also has an even older Bodhi (3.12 instead of 3.14). All that to say, the f29 spec file will be a bit different than this one. I will do F30 first and then work on F29. I will make the bodhi3 package be 3.12 (so it's the same version) and support those python2- packages too, even though that will make Miro a little bit sad. Sorry Miro. Let me know if you want to review that too or not - I can do it via a PR if you do. If I don't hear from either of you, I'll assume you don't want to review it ☺ I don't need to review anything, but if you'd like another set of eyes, feel free to cc me on the PR. As for the Python 2 bits, I only really care for rawhide. FEDORA-2019-352078fd2b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-352078fd2b Here is my commit for F29: https://src.fedoraproject.org/rpms/bodhi3/c/2d00cdba43dfe13cda171e2c75003a384c9350f6?branch=f29 Note that I kept using the python2-bodhi name for the Python 2 packages rather than calling them python3-bodhi3. This way they are the same content we offer now, and they don't conflict with the official Bodhi package, since it offers no Python 2 packages at all (Bodhi 4 does not support Python 2). FEDORA-2019-5ce9adadc1 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5ce9adadc1 bodhi-4.0.2-1.fc30, bodhi3-3.14.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-352078fd2b bodhi-4.0.2-1.fc29, bodhi3-3.12.0-200.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5ce9adadc1 bodhi-4.0.2-1.fc30, bodhi3-3.14.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. bodhi-4.0.2-1.fc29, bodhi3-3.12.0-200.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |