Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1716950

Summary:	Drop "sleep 1" from logrotate fragment?
Product:	[Fedora] Fedora	Reporter:	Marcos Mello <marcosfrm>
Component:	squid	Assignee:	Luboš Uhliarik <luhliari>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	anon.amish, code, jonathansteffan, luhliari
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	squid-4.8-5.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-26 17:23:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcos Mello 2019-06-04 12:56:07 UTC

It was added here:

https://src.fedoraproject.org/rpms/squid/c/a3a8a5ebbad17592a03daef0acef79dd3ef639ce?branch=master

At this point, logrotate already renamed old log files. "squid -k rotate" just sends SIGUSR1 to main Squid process and returns. Squid will reopen its logs and done. What is the rationale of sleeping there?

Comment 1 Ben Cotton 2019-08-13 16:57:09 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 2 Ben Cotton 2019-08-13 19:16:02 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 3 Marcos Mello 2019-10-08 10:56:01 UTC

If the "sleep 1" was added in case Squid continue writing to the logs after receiving SIGUSR1, the delaycompress logrotate option is much cleaner for that.

Comment 4 Luboš Uhliarik 2019-10-08 11:28:56 UTC

(In reply to Marcos Mello from comment #3)
> If the "sleep 1" was added in case Squid continue writing to the logs after
> receiving SIGUSR1, the delaycompress logrotate option is much cleaner for
> that.

I think, this was the case. I will use delaycompress in logrotate.

Comment 5 Fedora Update System 2019-10-08 12:46:58 UTC

FEDORA-2019-8bb0c4ccc7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8bb0c4ccc7

Comment 6 Fedora Update System 2019-10-09 03:25:19 UTC

squid-4.8-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8bb0c4ccc7

Comment 7 Fedora Update System 2019-10-26 17:23:45 UTC

squid-4.8-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.