Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1717658
Summary: | pycairo fails to build with Python 3.8 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | pycairo | Assignee: | Ralph Bean <rbean> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | urgent | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | caillon+fedoraproject, dan, gnome-sig, john.j5live, mclasen, pviktori, rbean, rhughes, rstrode, sandmann |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/pycairo/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-06-20 07:01:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1686977 |
Description
Miro Hrončok
2019-06-05 21:44:20 UTC
=================================== FAILURES ===================================
__________________________________ test_type ___________________________________
@pytest.mark.skipif(platform.python_implementation() == "PyPy", reason="PyPy")
def test_type():
t = cairo.Antialias
assert int in t.__mro__
assert isinstance(t(42), int)
assert isinstance(t(0), int)
assert issubclass(t, int)
with pytest.raises(TypeError):
t()
with pytest.raises(TypeError):
t(object())
with pytest.raises(TypeError):
type("foo", (t,), {})
assert hasattr(t, "DEFAULT")
assert t.DEFAULT == 0
assert t.__name__ == "Antialias"
assert t.__module__ == "cairo"
assert repr(t.DEFAULT) == "cairo.Antialias.DEFAULT"
assert repr(t(123456)) == "123456"
assert repr(t(0)) == "cairo.Antialias.DEFAULT"
> assert str(t(0)) == "0"
E AssertionError: assert 'cairo.Antialias.DEFAULT' == '0'
E - cairo.Antialias.DEFAULT
E + 0
tests/test_enums.py:35: AssertionError
=============== 1 failed, 258 passed, 4 skipped in 1.49 seconds ================
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged. Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required. Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/ This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need. If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do. We recommend always consulting with upstream, chances are this is already fixed there. This issue is blocking the Python 3.8 rebuilds. This package is part of the first 500 packages we build to bootstrap everything else. pygobject3 needs it to build. Unless this is resolved, we cannot proceed with the side tag rebuilds. This is due to a change in Python 3.8 (https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-python-behavior): Removed __str__ implementations from builtin types bool, int, float, complex and few classes from the standard library. They now inherit __str__() from object. As result, defining the __repr__() method in the subclass of these classes will affect they string representation. (Contributed by Serhiy Storchaka in bpo-36793.) This has been fixed upstream in https://github.com/pygobject/pycairo/commit/71c81741495cdce132b6f45a0f596d70909c1e4d It was not released yet. |