Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1718063

Summary: libreoffice fails to build with python 3.8
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: libreofficeAssignee: Stephan Bergmann <sbergman>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: caolanm, dtardon, erack, sbergman
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libreoffice-6.2.4.2-3.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-11 23:40:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    

Description Miro Hrončok 2019-06-06 19:47:02 UTC
libreoffice 1:6.2.4.2-1.fc30 fails to build with Python 3.8.0b1:

/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:123:1: error: cannot convert 'std::nullptr_t' to 'Py_ssize_t' {aka 'long int'} in initialization

Full logs at https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/libreoffice/




This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test in locally mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

We recommend always consulting with upstream, chances are this is already fixed there.

Comment 1 Stephan Bergmann 2019-06-07 07:01:51 UTC
So we apparently need to adapt to <https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa09372cc21673d> "bpo-36974: implement PEP 590 (GH-13185)".  Will take care.

Comment 2 Miro Hrončok 2019-06-07 18:05:04 UTC
Thanks, there's another problem. The build no longer links to libpython, resulting in undefined references to Python API like Py_InitializeEx.
Code that embeds Python (rather than building an extension module) needs to pass `--embed` to any `python3-config --libs` invocation to build with Python 3.8.
More information: 
https://docs.python.org/3.8/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

[build BIN] ridljar
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::lcl_ExceptionMessage(_object*, rtl::OUString const*)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:588: undefined reference to `PyObject_Str'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `PyStr_AsString(_object*)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_impl.hxx:85: undefined reference to `PyUnicode_AsUTF8'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::PyThreadAttach::~PyThreadAttach()':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:990: undefined reference to `PyThreadState_Clear'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:991: undefined reference to `PyEval_ReleaseThread'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::PyThreadDetach::PyThreadDetach()':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:997: undefined reference to `PyThreadState_Get'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::PyThreadAttach::PyThreadAttach(_is*)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:982: undefined reference to `PyThreadState_New'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:985: undefined reference to `PyEval_AcquireThread'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `importUnoModule':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:164: undefined reference to `PyImport_ImportModule'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:165: undefined reference to `PyErr_Occurred'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:168: undefined reference to `PyErr_Fetch'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:172: undefined reference to `PyObject_Str'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:176: undefined reference to `PyObject_Repr'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `PyStr_AsString(_object*)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_impl.hxx:85: undefined reference to `PyUnicode_AsUTF8'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_impl.hxx:85: undefined reference to `PyUnicode_AsUTF8'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `importUnoModule':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:182: undefined reference to `PyModule_GetDict'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::getRuntimeImpl(pyuno::PyRef&, pyuno::PyRef&) [clone .constprop.0]':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:138: undefined reference to `PyThreadState_Get'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:144: undefined reference to `PyImport_AddModule'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:151: undefined reference to `PyModule_GetDict'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:157: undefined reference to `PyDict_GetItemString'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o:/usr/include/python3.8/object.h:478: more undefined references to `_Py_Dealloc' follow
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::stRuntimeImpl::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:258: undefined reference to `_PyObject_New'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::Runtime::initialize(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:316: undefined reference to `PyDict_SetItemString'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::Runtime::any2PyObject(com::sun::star::uno::Any const&) const':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:398: undefined reference to `PyLong_FromLong'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_INCREF':
/usr/include/python3.8/object.h:459: undefined reference to `_Py_NoneStruct'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `pyuno::Runtime::any2PyObject(com::sun::star::uno::Any const&) const':
/builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:479: undefined reference to `PyTuple_New'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:480: undefined reference to `PyTuple_SetItem'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:481: undefined reference to `PyObject_CallObject'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:491: undefined reference to `PyTuple_New'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:494: undefined reference to `PyTuple_SetItem'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/pyuno/source/module/pyuno_runtime.cxx:497: undefined reference to `PyObject_SetAttrString'
/usr/bin/ld: /builddir/build/BUILD/libreoffice-6.2.4.2/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o: in function `_Py_DECREF':
/usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
/usr/bin/ld: /usr/include/python3.8/object.h:478: undefined reference to `_Py_Dealloc'
...

Comment 3 Miro Hrončok 2019-06-10 16:44:29 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

We recommend always consulting with upstream, chances are this is already fixed there.

Comment 4 Caolan McNamara 2019-06-10 19:20:36 UTC
sbergman is on vacation, I've pushed an additional tweak to (hopefully) link against `pkg-config python-$version-embed`

Comment 5 Miro Hrončok 2019-06-11 23:40:11 UTC
Thank you!