Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1718290

Summary: libratbag fails to build with Python 3.8
Product: [Fedora] Fedora Reporter: Petr Viktorin <pviktori>
Component: libratbagAssignee: Benjamin Tissoires <btissoir>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: btissoir, mhroncok, peter.hutterer, steve
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libratbag-0.9.905-3.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-17 03:05:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    

Description Petr Viktorin 2019-06-07 12:30:18 UTC
libratbag fails to build with Python 3.8.0b1.

The build no longer links to libpython, resulting in undefined references to Python API.
Code that embeds Python (rather than building an extension module) needs to pass `--embed` to any `python3-config --libs` invocation to build with Python 3.8.
More information: 
https://docs.python.org/3.8/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00924734-libratbag/

For all our attempts to build libratbag with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/libratbag/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.

Comment 1 Miro Hrončok 2019-07-10 14:43:53 UTC
Please respond.

Comment 2 Benjamin Tissoires 2019-07-10 14:46:33 UTC
Well, we have been trying to address the issue. But the root cause of the problem seems to be in meson, not in libratbag.
Our code doesn't call `python3-config --libs` at all, we rely on meson to set up the correct parameters.

So unless we are the only one meson package that makes use of `python3-config --libs`, we better fix meson to address all of the issues at once.

Comment 3 Miro Hrončok 2019-07-10 14:50:48 UTC
Could you report this to meson upstream then? Thank you.

Comment 4 Benjamin Tissoires 2019-07-10 15:00:01 UTC
> Could you report this to meson upstream then? Thank you.

https://github.com/mesonbuild/meson/issues/5629

There you go

Comment 5 Miro Hrončok 2019-07-10 15:03:58 UTC
Thank you.

Comment 6 Peter Hutterer 2019-07-17 03:05:30 UTC
Looks like the new dependency to use is python-embed.pc. Fixed now with libratbag-0.9.905-3.fc31

Comment 7 Miro Hrončok 2019-07-17 07:45:42 UTC
Thank You.