Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1719312

Summary: python-CommonMark fails to build with Python 3.8
Product: [Fedora] Fedora Reporter: Petr Viktorin <pviktori>
Component: python-CommonMarkAssignee: Julien Enselme <jujens>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: jujens, mhroncok, tir.karthi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-15 09:36:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    

Description Petr Viktorin 2019-06-11 13:41:59 UTC
python-CommonMark fails to build with Python 3.8.0b1.

The function time.clock(), used in commonmark/tests/run_spec_tests.py, has been removed. It was deprecated since Python 3.3. Use time.perf_counter() or time.process_time() instead, depending on your requirements, to have a well defined behavior. 
More info:
https://docs.python.org/3.8/whatsnew/3.8.html#api-and-feature-removals


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00934349-python-CommonMark/

For all our attempts to build python-CommonMark with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-CommonMark/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.

Comment 1 Karthikeyan Singaravelan 2019-06-29 05:36:50 UTC
Fixed upstream with https://github.com/readthedocs/commonmark.py/commit/cc242c43642a5249cd8aedd6c52dad257b95ab4b

Comment 2 Miro Hrončok 2019-07-10 15:16:30 UTC
Julien, could you please backport the fix?

Comment 3 Julien Enselme 2019-07-13 13:21:41 UTC
I just updated to 0.9.0 no rawhide which include the fix. You should be able to build on Python 3.8 now.

Comment 4 Miro Hrončok 2019-07-15 09:36:52 UTC
Thanks.