Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 172428
Summary: | Review Request: acpitool - A command line ACPI client for Linux | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://freeunix.dyndns.org:8088/site2/acpitool.shtml | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-11-11 20:40:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2005-11-04 10:37:16 UTC
The correct url is in fact: http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-2.src.rpm `-mcpu=' is deprecated. Use `-mtune=' or '-march=' instead. Specify CXXFLAGS to configure, like %configure CXXFLAGS=%{_optflags} Good: - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Have not tested yet. %configure allready defines CXXFLAGS to the right value; the issue is in the upstream configure.in script where compiler flags are setting although they shouldn't. I have patched the configure script, now it uses the optflags. See the srpm here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-3.src.rpm I also have contacted the upstream. Clean build now. APPROVED Normalize summary field for easy parsing |