Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1728063
Summary: | pew fails to build with Python 3.8 (too old python-virtualenv-clone) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | python-virtualenv-clone | Assignee: | Fedora Infrastructure SIG <infra-sig> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | infra-sig, m.cyprian, python-sig, rbean, tadej.j |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-08-14 08:51:44 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1686977 |
Description
Miro Hrončok
2019-07-08 23:20:26 UTC
Tadej? Could you please have a look? (In reply to Miro Hrončok from comment #1) > Tadej? Could you please have a look? Yes, I'll take a look. (In reply to Tadej Janež from comment #2) > > Yes, I'll take a look. So, Pew itself should support Python 3.8 without a change. I've tested it locally and also submitted an upstream pull request to start testing it on Python 3.8: https://github.com/berdario/pew/pull/214. The issue is that one of its dependencies, python-virtualenv-clone, has an outdated version in Fedora. Namely, version 0.2.6 from June 2015: https://src.fedoraproject.org/rpms/python-virtualenv-clone/blob/5d1c44488598abe298989e9f2525fae6c5a83a28/f/python-virtualenv-clone.spec#_7 https://pypi.org/project/virtualenv-clone/#history I've submitted a PR to update python-virtualenv-clone to version 0.5.3: https://src.fedoraproject.org/rpms/python-virtualenv-clone/pull-request/3 Miro, please take a look and review/merge. This version of python-virtualenv-clone contains fixes for the above issues regarding invalid escape sequences. Ideally, python-virtualenv-clone package should run its test suite so that this issue would be detected at its source. Nice analysis!
> Ideally, python-virtualenv-clone package should run its test suite so that this issue would be detected at its source.
I agree. Ideally, all packages should run their tests. Unfortunately python-virtualenv-clone is not maintained much.
> Nice analysis! Thanks! > Unfortunately python-virtualenv-clone is not maintained much. I can help maintain it since it is a vital dependency of Pew. So, someone from the Infra-sig team can add me as a co-maintainer through Pagure? I suppose that technically, Ralph would need to do that as Infra SIG doesn't have admin Rights. However I guess that at least some Infra SIG members have Pagure admin rights and can do that (or I can, if they agree). This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Miro, can this one be closed since updated python-virtualenv-clone has been pushed and Pew was built successfully with it (https://copr.fedorainfracloud.org/coprs/g/python/python3.8/build/993410/)? Sure thing! |