Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 172994
Summary: | Review Request: pork - Console based AIM client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://dev.ojnk.net | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-11-15 01:01:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Luke Macken
2005-11-11 21:43:44 UTC
* Use http://dl.sourceforge.net as the server for the Source tag, it allows direct download * Own the %{_datadir}/%{name} directory * Build fails in mock : /usr/bin/install -D -p -m 0755 doc/pork.1 /var/tmp/pork-0.99.8.1-1-root-mockbuild/usr/share/man/man1/ /usr/bin/install: cannot overwrite directory `/var/tmp/pork-0.99.8.1-1-root-mockbuild/usr/share/man/man1/' with non-directory Updated; builds clean in mock for me. http://people.redhat.com/lmacken/pork-0.99.8.1-2.src.rpm http://people.redhat.com/lmacken/pork.spec One last thing : please include the text of the license in %doc (at least). For example, you could add to the %files section the following line: %doc COPYING NEWS TODO CONTRIBUTERS STYLE README AUTHORS QUICK_START is already packaged in /usr/share/pork, and ChangeLog is empty for the moment. Woops.. definitely forgot the documentation. Fixed. http://people.redhat.com/lmacken/pork-0.99.8.1-3.src.rpm http://people.redhat.com/lmacken/pork.spec > Woops.. definitely forgot the documentation.
That's what the review process is for :)
Review for release 3:
* RPM name is OK
* Source pork-0.99.8.1.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list of pork looks OK
* Works fine
APPROVED
Imported. Thanks! |