Bug 173522

Comments on spec:

* the ver_ and rel_ macros serve no purpose; you should remove them
* don't include the name of the package in the summary
* use macros consistently: if you use %{__cat}, also use%{__perl}, %{__make}
etc.,  and if you use %{buildroot}, don't use $RPM_BUILD_ROOT.
* it's tidier to do edits of files etc. in %prep if possible, so I'd move the
generation of the LICENSE file from %install to %prep
* don't strip the binary; it'll result in a useless debuginfo package
* the groupadd and useradd commands could be combined into a single useradd command
* /bin/nologin does not exist
* don't delete accounts on package removal - see
http://www.redhat.com/archives/fedora-extras-commits/2005-June/msg00271.html
* /etc/init.d is a symlink to /etc/rc.d/init.d, so files should really go in the
latter directory rather than the former
* services shouldn't be enabled by default
* add dependencies for the pre/post/postun etc. scriptlets
* missing buildreq groff, needed to create cat8 manpage (which doesn't get
installed...)
* use a full URL for the source, so that "spectool --gf milter-regex.spec" will
retrieve the source
* the default username is edited in the code but not in the manpage
* if you use "install" rather than "cp" to install %SOURCE1 and %SOURCE2, you
can specify the modes of the files and not have to rely on them being set
correctly in the SRPM, which for non-644 files rpmlint doesn't like
* add a "%ghost /var/spool/milter-regex/sock" entry in the files list so that
the socket and directory get removed cleanly on package deletion
* add a "subsys" lockfile and a "reload" entry in the initscript to keep rpmlint
happy
* sendmail-devel >= 8.13.0 is needed as a buildreq since SMFIF_QUARANTINE is not
defined in sendmail < 8.13.0

I'll attach patches to this bug dealing with these issues. See what you think.

This is a nice, lightweight but powerful little filter and I wonder why I
haven't come across it before!

Created attachment 121234 [details]
Spec file patch addressing issues from Comment #1

Created attachment 121235 [details]
initscript patch addressing issues raised in Comment #1

(In reply to comment #1)
> Comments on spec:
> 
> * the ver_ and rel_ macros serve no purpose; you should remove them
> * don't include the name of the package in the summary
> * use macros consistently: if you use %{__cat}, also use%{__perl}, %{__make}
> etc.,  and if you use %{buildroot}, don't use $RPM_BUILD_ROOT.
> * it's tidier to do edits of files etc. in %prep if possible, so I'd move the
> generation of the LICENSE file from %install to %prep
> * don't strip the binary; it'll result in a useless debuginfo package
> * the groupadd and useradd commands could be combined into a single useradd
command
> * /bin/nologin does not exist
> * don't delete accounts on package removal - see
> http://www.redhat.com/archives/fedora-extras-commits/2005-June/msg00271.html
> * /etc/init.d is a symlink to /etc/rc.d/init.d, so files should really go in the
> latter directory rather than the former
> * services shouldn't be enabled by default
> * add dependencies for the pre/post/postun etc. scriptlets
> * missing buildreq groff, needed to create cat8 manpage (which doesn't get
> installed...)
> * use a full URL for the source, so that "spectool --gf milter-regex.spec" will
> retrieve the source
> * the default username is edited in the code but not in the manpage
> * if you use "install" rather than "cp" to install %SOURCE1 and %SOURCE2, you
> can specify the modes of the files and not have to rely on them being set
> correctly in the SRPM, which for non-644 files rpmlint doesn't like
> * add a "%ghost /var/spool/milter-regex/sock" entry in the files list so that
> the socket and directory get removed cleanly on package deletion
> * add a "subsys" lockfile and a "reload" entry in the initscript to keep rpmlint
> happy
> * sendmail-devel >= 8.13.0 is needed as a buildreq since SMFIF_QUARANTINE is not
> defined in sendmail < 8.13.0
> 
> I'll attach patches to this bug dealing with these issues. See what you think.
> 
> This is a nice, lightweight but powerful little filter and I wonder why I
> haven't come across it before!
> 

(In reply to comment #1)
> Comments on spec:
> 
> * the ver_ and rel_ macros serve no purpose; you should remove them
> * don't include the name of the package in the summary
> * use macros consistently: if you use %{__cat}, also use%{__perl}, %{__make}
> etc.,  and if you use %{buildroot}, don't use $RPM_BUILD_ROOT.
> * it's tidier to do edits of files etc. in %prep if possible, so I'd move the
> generation of the LICENSE file from %install to %prep
> * don't strip the binary; it'll result in a useless debuginfo package
> * the groupadd and useradd commands could be combined into a single useradd
command
> * /bin/nologin does not exist
> * don't delete accounts on package removal - see
> http://www.redhat.com/archives/fedora-extras-commits/2005-June/msg00271.html
> * /etc/init.d is a symlink to /etc/rc.d/init.d, so files should really go in the
> latter directory rather than the former
> * services shouldn't be enabled by default
> * add dependencies for the pre/post/postun etc. scriptlets
> * missing buildreq groff, needed to create cat8 manpage (which doesn't get
> installed...)
> * use a full URL for the source, so that "spectool --gf milter-regex.spec" will
> retrieve the source
> * the default username is edited in the code but not in the manpage
> * if you use "install" rather than "cp" to install %SOURCE1 and %SOURCE2, you
> can specify the modes of the files and not have to rely on them being set
> correctly in the SRPM, which for non-644 files rpmlint doesn't like
> * add a "%ghost /var/spool/milter-regex/sock" entry in the files list so that
> the socket and directory get removed cleanly on package deletion
> * add a "subsys" lockfile and a "reload" entry in the initscript to keep rpmlint
> happy
> * sendmail-devel >= 8.13.0 is needed as a buildreq since SMFIF_QUARANTINE is not
> defined in sendmail < 8.13.0
> 
> I'll attach patches to this bug dealing with these issues. See what you think.
> 
> This is a nice, lightweight but powerful little filter and I wonder why I
> haven't come across it before!
> 
   
  
  (In reply to comment #2)
> Created an attachment (id=121234) [edit]
> Spec file patch addressing issues from Comment #1
> 
 I have corrected all flaws that you have pointed, sorry for the mess. I have to
 try harder from now (sorry for my bad english).
 http://146.83.196.48/~vramirez/mregex/milter-regex-1.6-3.src.rpm
  
  I have not tried it under SElinux, may arise some problem? 
    

This ticket has been closed NOTABUG - why was that?

I've been using this package for some time (with SELInux enabled) and would like
to see it in Extras.

If the submitter is no longer interested in this package, I propose to resubmit
it myself, probably late next week when I should have more time.

Since the original submitter no longer seems to be interested in this package,
I've resubmitted it myself and will close this one as a duplicate.


*** This bug has been marked as a duplicate of 189611 ***