Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 173549

Summary:	Review Request: xfce4-mount-plugin
Product:	[Fedora] Fedora	Reporter:	Christoph Wickert <cwickert>
Component:	Package Review	Assignee:	Luya Tshimbalanga <luya_tfz>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, wtogami
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://xfce-goodies.berlios.de/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-01-22 20:31:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Christoph Wickert 2005-11-18 01:44:00 UTC

Spec Name or Url:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-mount-plugin.spec
SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-mount-plugin-0.3.2-2.fc4.src.rpm
Description: 
Mount and unmount filesystems from the Xfce panel.

Comments:
This is not the latest upstream release but the latest to build on XFCE 4.2.x, modemlight-plugin-4.x series is for upcoming xfce 4.3 only.
rpmlint is clean
License GPL and included

Comment 1 Christoph Wickert 2005-12-01 13:28:05 UTC

- Add libxfcegui4-devel BuildReqs.
- Fix %defattr.

New SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-mount-plugin-0.3.2-3.fc4.src.rpm

Comment 2 Luya Tshimbalanga 2006-01-19 23:16:44 UTC

Here is a detailed review:
+ mock succesfully built the srpms
+ rpmlint did not complain about errors
+ package conforms to the package guideline (spec name, version, ...)
+ versionning of the package follows Fedora Extras standards
+ tarball from upstream  match with the tarball from source rpm.
+ package is under GPL license thus following legal section of PackagingGuidelines
+ no error encountered after installing and removing package

Following this review, this package is ready to be in Fedora Extras thus
changing the status to FE-ACCEPT.

Comment 3 Luya Tshimbalanga 2006-01-19 23:19:17 UTC

Forgot to add on this quote:
+ tarball from upstream  match with the tarball from source rpm.

I used both md5sum and sha1sum

Comment 4 Christoph Wickert 2006-01-22 20:31:28 UTC

(In reply to comment #3)
>
> I used both md5sum and sha1sum

one should be enough ;)

Updated the package to 0.3.3 after import into cvs. 0.3.3-1 builds fine on Core
3 and 4, rawhide is inconsistent atm. Closing.