Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1736807

Summary: appliance-creator fails on "Writing GRUB Legacy config." on aarch64 EC2
Product: [Fedora] Fedora Reporter: Warren Togami <wtogami>
Component: appliance-toolsAssignee: Neal Gompa <ngompa13>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: agrimm, david.abdurachmanov, dhuff, ngompa13
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-24 18:07:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 245418    

Description Warren Togami 2019-08-02 05:28:47 UTC
Description of problem:
Fedora 30 aarch64 appliance-creator invoked with the cmdline and kickstart config from Bug #1736804 fails with this traceback.

Writing kickstart file.
Writing GRUB Legacy config.
Traceback (most recent call last):
  File "/usr/bin/appliance-creator", line 193, in <module>
    sys.exit(main())
  File "/usr/bin/appliance-creator", line 155, in main
    creator.configure()
  File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 799, in configure
    self._create_bootconfig()
  File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 536, in _create_bootconfig
    self._create_grub_config()
  File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 286, in _create_grub_config
    grub += "splashimage=(hd0,%d)%s/grub/splash.xpm.gz\n" % (bootdevnum, prefix)
TypeError: %d format: a number is required, not NoneType

/usr/lib/python3.7/site-packages/appcreate/appliance.py line 536 ...
    def _create_bootconfig(self):
        logging.debug("Writing kickstart file.")
        self._write_kickstart()
        # For EC2 lets make a grub Legacy config file
        # (only if bootloader is enabled)
        if ((hasattr(self.ks.handler.bootloader, "disabled") and self.ks.handler.bootloader.disabled is False) and
           (hasattr(self.ks.handler.bootloader, "location") and self.ks.handler.bootloader.location != "none")):
            logging.debug("Writing GRUB Legacy config.")
            self._create_grub_config()

I'm guessing GRUB Legacy is meant only for x86_64, and nobody tried aarch64 appliance-creator on EC2 aarch64 recently?


Version-Release number of selected component (if applicable):
appliance-tools-009.0-5.fc30.noarch

Comment 1 Warren Togami 2019-08-05 14:14:31 UTC
https://pagure.io/appliance-tools/c/96b4e257892d4695b5ffe61ddf0e3586acf5de2f?branch=master
This traceback was introduced in this commit during late 2018.

I suspect nobody noticed this error because imagefactory is used for aarch64 images instead of appliance-creator.

Comment 2 Ben Cotton 2019-08-13 17:10:01 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 3 Ben Cotton 2019-08-13 18:33:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 4 Ben Cotton 2020-11-03 15:29:28 UTC
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2020-11-24 18:07:49 UTC
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.