Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1736943

Summary: varnish-modules: FTBFS in Fedora rawhide/f31
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: varnish-modulesAssignee: Ingvar Hagelund <ingvar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: dridi.boukelmoune, ingvar, luhliari, nils.goroll
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-28 23:01:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1700317, 1732841    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-08-02 09:41:22 UTC
varnish-modules failed to build from source in Fedora rawhide/f31

https://koji.fedoraproject.org/koji/taskinfo?taskID=36637967


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Please fix varnish-modules at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
varnish-modules will be orphaned. Before branching of Fedora 32,
varnish-modules will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-08-02 09:41:26 UTC
Created attachment 1599777 [details]
build.log

Comment 2 Fedora Release Engineering 2019-08-02 09:41:28 UTC
Created attachment 1599778 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2019-08-02 09:41:29 UTC
Created attachment 1599779 [details]
state.log

Comment 4 Ben Cotton 2019-08-13 16:52:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 5 Ben Cotton 2019-08-13 18:08:17 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 6 Fedora Release Engineering 2019-09-22 04:37:05 UTC
Dear Maintainer,

your package has not been built successfully in 31. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. Following the latest policy for such packages [2], your package
can be orphaned if this bug remains in NEW state more than 8 weeks.

A week before the mass branching of Fedora 32 according to the schedule [3],
any packages which still have open FTBFS bugs from Fedora 31 will be retired.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedoraproject.org/wiki/Releases/32/Schedule

Comment 7 Dridi Boukelmoune 2019-09-22 08:54:31 UTC
Upstream hat on: this package doesn't currently support Varnish > 6.0.x and while there are community compatibility patches for Varnish >= 6.1 those are unfit for upstream adoption.

Fedora (hat) on: I'm not sure whether those patches are available for Varnish 6.2 and don't have time as a co-maintainer to work on this.

Comment 8 Ingvar Hagelund 2019-09-24 09:16:40 UTC
I am willing to apply patches from Nils Goroll's tree*, to make varnish-modules compile against varnish-6.3.0. If I just add the lot, up to his master head, it runs the test suite. That is good enough for me.

Now, not being a real C hacker, I am unable to pick which of his patches are necessary for forward porting, and which he is adding for other purposes.

Easiest way out for me is of course to skip all the patching, and just use Nils Goroll's tree as upstream for varnish-modules in rawhide, but that would mean a downstream fork. I don't know what the Fedora Policy says on this.


Ingvar


*) https://github.com/nigoroll/varnish-modules

Comment 9 Nils Goroll 2019-09-25 13:36:57 UTC
I think it would be easiest to just apply a diff to fe1a98112f22cab899b651da38b0709bce4f458f
this should not contain any changes but compatiblity

Comment 10 Ingvar Hagelund 2019-09-28 23:01:26 UTC
Thanks Nils

Fixed in rawhide, varnish-modules-0.15.0-7