Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 174181
| Summary: | Review Request: python-simpy Python simulation framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sarantis Paskalis <sarantis> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://gallagher.di.uoa.gr/rpms/python-simpy/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-12-26 11:27:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Sarantis Paskalis
2005-11-25 14:17:40 UTC
SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires: tkinter needed. The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one or the other. file says "python-simpy.spec: lex description text" Follows python spec template - rpmlint does not output anything I would not call this python-simpy, simpy is sufficient, as it is not a python extension but a SIMulation in PYthon. Debian seems to call it python-simpy, however. Your choice. You removed the source documentation. Consider packaging it as a seperate docs subpackage. The patch removes all shebangs. Why, is this to quiet rpmlint? - license (LGPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386, is noarch - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - nothing in %doc affects runtime - no need for .desktop file (In reply to comment #1) > SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires: > tkinter needed. done. > The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one > or the other. file says "python-simpy.spec: lex description text" It is ASCII though. file -i says python-simpy.spec: text/x-java; charset=us-ascii I think the first lines confuse the guessing done by file's logic. > - rpmlint does not output anything > > I would not call this python-simpy, simpy is sufficient, as it is not a python > extension but a SIMulation in PYthon. Debian seems to call it python-simpy, > however. Your choice. It is not a standalone application, but a simulation framework. One writes simulations in python using this framework, so I think I'll keep the name. > You removed the source documentation. Consider packaging it as a seperate docs > subpackage. done. > The patch removes all shebangs. Why, is this to quiet rpmlint? Yes. I have no strong feelings on this, I can remove it. The modules from which the shebangs are removed are not supposed to be executed directly, and some example scripts I wrote did not show any problems with this patch. I'll take it upstream anyway to see what the authors think. Thanks for the review. New versions: http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy.spec http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-1.6.1-2.src.rpm http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-1.6.1-2.noarch.rpm http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-doc-1.6.1-2.noarch.rpm Looks good. APPROVED. Imported to CVS, packages built for FC-3, FC-4 and devel. Closing. |