Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 174320
Summary: | Review Request: gcdmaster - Gnome Audio CD mastering | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Denis Leroy <denisleroy> |
Component: | Package Review | Assignee: | Michael A. Peters <mpeters> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, wtogami |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.poolshark.org/src/gcdmaster-1.2.1-1.src.rpm | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-04 22:36:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Denis Leroy
2005-11-27 21:29:42 UTC
Good * Named according to PackageNamingGuidelines * Spec file matches base package name * Package meets packaging guidelines * Licensed with appropriate licence (GPL), matches license in upstream package * Spec file written in understandable americano english * md5sum of source tarball matches upstream * builds in mock on fc4 x86 * No un-necessary BuildRequires * No locales * Package owns all directories it creates * Proper perms and %defattr() * No libtool files packaged * Proper desktop file - proper update-mime-database & update-desktop-database in scriptlets * rpmlint output: [mpeters@utility result]$ ls *.rpm gcdmaster-1.2.1-1.fc4.i386.rpm gcdmaster-debuginfo-1.2.1-1.fc4.i386.rpm gcdmaster-1.2.1-1.fc4.src.rpm [mpeters@utility result]$ rpmlint *.rpm E: gcdmaster zero-length /usr/share/doc/gcdmaster-1.2.1/NEWS [mpeters@utility result]$ build pretty clean: [mpeters@utility result]$ grep "warning" build.log dlg_a.c:255: warning: ignoring return value of 'sscanf', declared with attribute warn_unused_result dlg_a.c:262: warning: ignoring return value of 'sscanf', declared with attribute warn_unused_result dlg_a.c:269: warning: ignoring return value of 'sscanf', declared with attribute warn_unused_result AudioCDView.cc:888: warning: ignoring return value of 'int sscanf(const char*, const char*, ...)', declared with attribute warn_unused_result warning: Could not canonicalize hostname: utility.mpeters.local [mpeters@utility result]$ Needs Work * Please remove the INSTALL file from %doc It is meaningless to the end user. * Please remove NEWS file - it's empty Suggestions Not required, would be nice though - Allow for a user defined macro that will build with mp3 support if user has the needed stuff for mp3 support. IE - rpmbuild --define 'mp3 1' --rebuild src.rpm would try to rebuild w/ mp3 support enabled. I seem to remember some other packages that did this in the past, I think an audio editing app did. -=- At any rate - with the removal of the INSTALL and NEWS from %doc, I'll approve Michael, thanks for your review. http://www.poolshark.org/src/gcdmaster.spec http://www.poolshark.org/src/gcdmaster-1.2.1-2.src.rpm I'll import shortly. I removed the explicit disabling of MP3 support so that configure will fall back on autodetection. That means that if you compile the src.rpm with libmad-devel installed, mp3 support will be built in (that support is "neutral" wrt packaging, it doesn't add files to the package or anything like that). http://www.poolshark.org/src/gcdmaster.spec http://www.poolshark.org/src/gcdmaster-1.2.1-3.src.rpm Damn i should finish my coffee before i do these things. Mp3 support is obviously not RPM-neutral since you might accidentally tie the built RPM to libmad.so.0 if libmad-devel happens to be installed. I changed my mind here and implement your idea. Compiling with "rpmbuild --define '_with_mp3 1'" will enable the mp3 support auto-detection. Approved > Damn i should finish my coffee before i do these things. Mp3 support is
> obviously not RPM-neutral since you might accidentally tie the built RPM to
> libmad.so.0 if libmad-devel happens to be installed.
This is not an issue for Extras, because each build happens from a minimal
buildroot with only listed deps installed.
> --define '_with_mp3 1'" will enable the mp3 support auto-detection.
Better: pass "--with mp3" as an argument to rpmbuild. It will set
the _with_mp3 macro to 1.
Built :-) |