Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 174510 (perl-Crypt-DH)
Summary: | Review Request: perl-Crypt-DH | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Crypt-DH/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-09 10:23:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Paul Howarth
2005-11-29 16:44:41 UTC
> (note to reviewers: %check takes a *long* time)
A true understatement ;)
May-be you should consider to add a --without checks rpmbuild option (defaulting
to --with checks) to ease rebuilding of this package.
Also, I presume you also tested this with Math::Pari installed (I haven't),
because if I understand this package's working principles correctly, it will
pick up and use Math::Pari conditionally, should it be installed.
I.e. should Pari be installed, this could cause Heisenbugs, which could be hard
to handle. Or are you planning to make Math::Pari a mandatory requirement, once
Math::Pari is in FE?
Packaging-wise: Package is clean - APPROVED
(In reply to comment #1) > > (note to reviewers: %check takes a *long* time) > A true understatement ;) > > > May-be you should consider to add a --without checks rpmbuild option (defaulting > to --with checks) to ease rebuilding of this package. Added in cvs. > Also, I presume you also tested this with Math::Pari installed (I haven't), > because if I understand this package's working principles correctly, it will > pick up and use Math::Pari conditionally, should it be installed. I hadn't actually built Math::Pari at the time I submitted this package, but I've tested it since. Rather surprisingly, neither Math::Pari nor Math::GMP seem to speed up the test suite by any noticeable amount. > I.e. should Pari be installed, this could cause Heisenbugs, which could be hard > to handle. Or are you planning to make Math::Pari a mandatory requirement, once > Math::Pari is in FE? I'll probably do that, yes. > Packaging-wise: Package is clean - APPROVED Imported and building. Let's see if the buildsystem times out the test suite... Build on target fedora-development-extras succeeded Package Change Request ====================== Package Name: perl-Crypt-DH New Branches: EL-4 EL-5 Owners: pghmcfc InitialCC: perl-sig cvs done. |