Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175144
Summary: | Review Request: munin - Network-wide graphing framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
Component: | Package Review | Assignee: | Ed Hill <ed> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, lkundrak |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.scrye.com/~kevin/munin/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-14 19:38:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Kevin Fenzi
2005-12-06 22:23:19 UTC
Hi Kevin, this isn't a thorough review but it is a start: nits: - rpmlint reports: E: munin non-standard-uid /var/www/html/munin munin E: munin non-standard-gid /var/www/html/munin munin E: munin non-standard-uid /var/log/munin munin E: munin non-standard-gid /var/log/munin munin E: munin non-standard-uid /var/lib/munin munin E: munin non-standard-gid /var/lib/munin munin E: munin non-standard-uid /var/run/munin munin E: munin non-standard-gid /var/run/munin munin E: munin-node non-standard-uid /var/lib/munin/plugin-state munin E: munin-node non-standard-gid /var/lib/munin/plugin-state munin which seem to be safe to ignore - running "yum localinstall [...the two noarch rpms...]" results in two errors: Error: Missing Dependency: perl(DBD::Sybase) is needed by \ package munin-node Error: Missing Dependency: perl(Net::SNMP) is needed by \ package munin-node which I have no idea how to fix. Perhaps someone else has a clue whats happening here -- is it somehow pulling in unnecessary dependencies...? good: + source matches upstream + spec is readable and looks OK + code not content + builds in mock on FC-4 + appears to use the correct syntax wrt user and group creation: http://fedoraproject.org/wiki/PackageUserCreation + dir ownership looks good Thats for taking a look! There is one plugin that needs DBD::Sybase, which is easy to remove for now... There are several more plugins that use Net::SNMP, but it turns out that the main configure program also tries to use it. It's not however required, if it can't load the module it just doesn't use any SNMP functionality. I could possibly remove the Net::SNMP checks and plugins, will investigate that... Or possibly package Net::SNMP. I looked at packaging Net::SNMP, but it requires perl-Crypt-DES, which has a BSD with advertising License, so not sure it would be acceptable. I have also asked upstream about supporting net-snmp-perl (which is already in core) instead of Net::SNMP. In the mean time I have made a new version that removes the DBD::Sybase and Net:SNMP requirements. They can be added back in later when upstream supports net-snmp-perl or perl-Net-SNMP is added to extras. new SPEC: http://www.scrye.com/~kevin/munin/munin.spec new src.rpm: http://www.scrye.com/~kevin/munin/munin-1.2.4-2.fc5.src.rpm diff of spec from last version: 3c3 < Release: 1%{?dist} --- > Release: 2%{?dist} 88c88 < install-main install-node install-node-plugins install-doc install-man --- > install-main install-node-non-snmp install-node-plugins install-doc install-man 107a108,115 > # > # remove the Net::SNMP and Sybase plugins for now, as they need perl modules > # that are not in extras. We can readd them when/if those modules are added. > # > rm -f %{buildroot}/usr/share/munin/plugins/pm3users_ > rm -f %{buildroot}/usr/share/munin/plugins/snmp_* > rm -f %{buildroot}/usr/share/munin/plugins/sybase_space > 202d209 < %{_sbindir}/munin-node-configure-snmp 217a225,227 > * Mon Dec 12 2005 Kevin Fenzi <kevin> - 1.2.4-2 > - Removed plugins that require Net-SNMP and Sybase > perl-Crypt-DES is bug 168580 (In reply to comment #3) > I looked at packaging Net::SNMP, but it requires perl-Crypt-DES, which has a BSD > with advertising License, so not sure it would be acceptable. perl-Crypt-DES is currently under review for Extras (Bug 168580) and I'd appreciate some feedback on this license issue myself as the reviewer. The latest SRPM (munin-1.2.4-2.fc5.src.rpm) builds in mock on FC-4 and installs without any problems. So, I don't think there are any blockers left here. Assuming that the licenses are all acceptable, I think it would be nice for munin to support all of its plug-ins (inc. both the Sybase interface and the SNMP bits). But they are, ultimately, just plug-ins -- not essential bits of functionality. And, being plug-ins, they can be readily enabled as soon as the necessary supporting packages are included in Fedora. So if the submitter agrees to work with others to help enable the plug-ins (that is, when the other packages are ready) then this package is APPROVED. Surely. It would be nice to have the SNMP plugins in particular, but munin is very useful without them. :) I would be happy to enable the plugins as soon as I can. Right now, that looks like two possibilities: - The license on perl-Crypt-DES is ok and it gets approved. Then, I can submit perl-Net-SNMP and re-enable those plugins when that gets approved. - I talked with upstream and they are fine with switching to net-snmp-perl, but would need patches to do so. I might have time over the holidays to look at that. Thanks for the approval. I will import and test on fc3/fc4 to see what branches should be requested. imported and built on fc3/fc4/devel. I'd love to see this in EPEL, and be thankful if you could maintain it. If you have a reason not to, I'll gladly do so. (similar request has been filed for perl-HTML-Template, which is its only missing dependency to my knowledge). Thanks! Yes, I have been working on getting all the perl deps in for the last few months. ;) perl-HTML-Template is all thats left. ;) |