Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175198
Summary:  Review Request: perlMathPari  

Product:  [Fedora] Fedora  Reporter:  Paul Howarth <paul> 
Component:  Package Review  Assignee:  Jose Pedro Oliveira <jose.p.oliveira.oss> 
Status:  CLOSED NEXTRELEASE  QA Contact:  David Lawrence <dkl> 
Severity:  medium  Docs Contact:  
Priority:  medium  
Version:  rawhide  CC:  fedoraextraslist, j 
Target Milestone:    Flags:  kevin:
fedoracvs+

Target Release:    
Hardware:  All  
OS:  Linux  
Whiteboard:  
Fixed In Version:  Doc Type:  Bug Fix  
Doc Text:  Story Points:    
Clone Of:  Environment:  
Last Closed:  20060419 06:56:19 UTC  Type:   
Regression:    Mount Type:   
Documentation:    CRM:  
Verified Versions:  Category:    
oVirt Team:    RHEL 7.3 requirements from Atomic Host:  
Cloudforms Team:    Target Upstream Version:  
Embargoed:  
Bug Depends On:  
Bug Blocks:  163779, 183374, 183889 
Description
Paul Howarth
20051207 17:12:45 UTC
Paul, 1) Would you mind just hardcoding the pari version? The current construct appears to be error prone: for example, it doesn't handle the current pari development version  2.2.12  or any other version component with more than 1 digit. If I assume the Math::Pari version as 2.021201 it will output 2.212 as the pari version (it should output 2.2.12). $ echo 2.021201  perl pi e 'tr/0/./;s/\.+/./;s/\.[^.]*$//' 2.212 2) There is also a new version available. Could you update? Diff from MathPari2.010702 to MathPari2.010703 http://search.cpan.org/diff?from=MathPari2.010702&to=MathPari2.010703 jpo (In reply to comment #1) > 1) Would you mind just hardcoding the pari version? The current construct > appears to be error prone: for example, it doesn't handle the current pari > development version  2.2.12  or any other version component with more > than 1 digit. > > If I assume the Math::Pari version as 2.021201 it will output 2.212 as > the pari version (it should output 2.2.12). > > $ echo 2.021201  perl pi e 'tr/0/./;s/\.+/./;s/\.[^.]*$//' > 2.212 I'd really prefer to only have to change the one version number in the spec if possible, since (a) it makes the spec easier to maintain, and (b) it should ensure that I'm always using the "supported" version of the pari library. I've updated the expression, which should get it right in all cases now I think. > 2) There is also a new version available. Could you update? > > Diff from MathPari2.010702 to MathPari2.010703 > http://search.cpan.org/diff?from=MathPari2.010702&to=MathPari2.010703 Done: http://www.cityfan.org/~paul/extras/perlMathPari/perlMathPari2.0107031.src.rpm Spec URL unchanged. Updated SRPM (new upstream version): http://www.cityfan.org/~paul/extras/perlMathPari/perlMathPari2.0107041.src.rpm Spec URL unchanged. Paul, Sorry for the delay. MD5SUMS: c88e8dde7657098b608b07f75fbde19b perlMathPari2.0107041.src.rpm 0397da31fbe4f5485c4e7094c3661c5a MathPari2.010704.tar.gz 357b7a42e89e2761a5367bbcbfcca5f2 pari2.1.7.tgz 2b9ed7df1bb67895b19aa7d195f2b692 perlMathPari.spec Good: * MathPari tarball MD5 digest verified against a CPAN copy * pari 2.1.7 tarball MD5 digest verified * URL and Sources URLs are valid * License verified (README file) * perl(:MODULE_COMPAT_xxx) present * perl vendor libs present * File permissions are OK * Builds without problems in FC3 and FC5 * (Un)installs without problems in FC3 and FC5 NeedsWork: * the files libPARI.dumb.pod, Math::libPARI.dumb.3pm.gz are duplicates of libPARI.pod, Math::libPARI.3pm.gz (ok, they have slightly different formats) (Easy fix  just remove the *dumb* files) Other minor notes: * Would be nice to have Term::Gnuplot around to improve the test coverage (In reply to comment #4) > NeedsWork: > * the files libPARI.dumb.pod, Math::libPARI.dumb.3pm.gz are duplicates > of libPARI.pod, Math::libPARI.3pm.gz (ok, they have slightly different > formats) > (Easy fix  just remove the *dumb* files) Fixed in 2: http://www.cityfan.org/~paul/extras/perlMathPari/perlMathPari.spec http://www.cityfan.org/~paul/extras/perlMathPari/perlMathPari2.0107042.fc5.src.rpm > Other minor notes: > * Would be nice to have Term::Gnuplot around to improve the test coverage Added to ToDo list. APPROVED MD5SUMS: 6b44f5a3e572896883e83cff57581fe6 perlMathPari2.0107042.fc5.src.rpm 0397da31fbe4f5485c4e7094c3661c5a MathPari2.010704.tar.gz 357b7a42e89e2761a5367bbcbfcca5f2 pari2.1.7.tgz e912c8aefcc2c2aaae4daaf62441545d perlMathPari.spec Thanks for the review. Build on target fedoradevelopmentextras succeeded. Build logs may be found at http://buildsys.fedoraproject.org/logs/fedoradevelopmentextras/7835perlMathPari2.0107042.fc6/ Branch requests for FC4 and FC5 made. Package Change Request ====================== Package Name: perlMathPari New Branches: EL4 EL5 cvs done. 