Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175494
| Summary: | Review Request: new | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <redhat> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-12-19 22:30:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
W. Michael Petullo
2005-12-11 22:28:18 UTC
*** Bug 175496 has been marked as a duplicate of this bug. *** - package meets naming guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Stuff needing work:
- warnings about duplicate files
- %doc %{_mandir} is useless, rpm knows about man already
- empty NEWS and FAQ aren't useful, don't include
- Don't need to list every file in %files, including a directory includes its
contents. Wildcards accepted, useful for including everything but not owning the
directory. So you can do:
%files
%{_bindir}/*
%{_datadir}/new
%{_mandir}/*/*
- Your header and pkgconfig files should be in a seperate devel sub package.
This devel package should require the base new package, the exact same version.
See PackageReviewGuidelines on the wiki.
Changes recommended by John: Spec Name or Url: http://flyn.org/SRPMS/new.spec SRPM Name or Url: http://www.flyn.org/projects/new/new-1.3.5-2.src.rpm Description: A simple template system for creating text files. Builds and works. rpmlint complains about: E: new non-executable-script /usr/share/new/templates/missing/default 0644 E: new non-executable-script /usr/share/new/templates/py/default 0644 E: new non-executable-script /usr/share/new/templates/sh/default 0644 W: new-devel no-documentation but these can be ignored, templates aren't executable. devel subpackage included, no .la files. Remainder of review in comment 2. APPROVED > %files devel
> %{_libdir}/pkgconfig/new.pc
> %{_includedir}/new
> %{_libdir}/lib*.so
Missing %defattr(..). If built, files in binary package will be
owned by the build user.
new-1.3.5-3 is now in CVS. This version fixes the issue raised in command #5. |