Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 175551

Summary:	Review Request: asa - Convert Fortran carriage control characters
Product:	[Fedora] Fedora	Reporter:	Patrice Dumas <pertusus>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-01-29 21:31:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Patrice Dumas 2005-12-12 18:41:34 UTC

SRPM Name or Url: http://www.environnement.ens.fr/docs/fc-srpms/asa-1.2-1.src.rpm
Description: 

A POSIX.2 compliant asa(1), for converting Fortran carriage control
characters to line printer control characters.

Comment 1 Patrice Dumas 2006-01-29 11:12:40 UTC

I made a mistake in the srpm url, it is
http://www.environnement.ens.fr/perso/dumas/fc-srpms/asa-1.2-1.src.rpm

Comment 2 John Mahowald 2006-01-29 19:59:32 UTC

To clarify, the use of the Debian archive because it has the latest 1.2?

Good:

- rpmlint checks clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 3 Ed Hill 2006-01-29 20:02:59 UTC

Hi Patrice, I think this is a candidate for the simplest and smallest 
package submitted to Fedora Extras.  And it looks like you've done it 
correctly:

 + source matches upstream
 + very simple (almost trivial) package
 + spec looks clean & good -- no obvious errors
 + builds on FC4
 + rpmlint reports no errors or warnings
 + license is correct and correctly included

so its APPROVED.

Comment 4 Ed Hill 2006-01-29 20:08:39 UTC

Hi John, you beat me to it by a few minutes so you clearly get credit for 
the review here.  And I apologize for hitting the "submit anyway" button 
without paying closer attention to what was going on.  I've re-assigned 
the bug back to you so it should be un-done.

And, anyway, its nice to see that we agree...  :-)

Comment 5 Patrice Dumas 2006-01-29 21:31:58 UTC

I used the 1.2 from debian as I couldn't find it anywhere else and it has some
fixes with regard with 1.1, especially in the Makefile.

This is my first doubly approved package. Maybe because it is such a complex
package? ;-)