Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1757463
Summary: | flake8 fails on epel8 due to missing dependency on mccabe and entrypoints | ||
---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Sandro Bonazzola <sbonazzo> |
Component: | python-flake8 | Assignee: | Troy Dawson <tdawson> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | urgent | Docs Contact: | |
Priority: | unspecified | ||
Version: | epel8 | CC: | abologna, berrange, kdreyer, me, mrunge, sgallagh, smooge |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | python-flake8-3.7.7-5.fc31 python-flake8-3.7.7-6.el8 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-12-11 01:59:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1774260 | ||
Bug Blocks: | 1757320, 1774038 |
Description
Sandro Bonazzola
2019-10-01 15:32:04 UTC
flake8 needed in an ovirt package build: https://gerrit.ovirt.org/#/c/103726/ I don't do epel builds for a long time now, and I'd like to keep it that way. I see https://src.fedoraproject.org/rpms/python-flake8/c/aa80b5f09c9aaf77a95c7b7f7cb81c368636af7b?branch=master which dropped the deps even on rawhide. I'll the package in Fedora though. FEDORA-2019-67474a7206 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-67474a7206 FEDORA-EPEL-2019-2c080a59a6 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-2c080a59a6 python-flake8-3.7.7-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-67474a7206 python-flake8-3.7.7-5.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-2c080a59a6 Sorry, now failing on [2019-10-07T13:26:12.364Z] Traceback (most recent call last): [2019-10-07T13:26:12.365Z] File "/usr/bin/flake8", line 6, in <module> [2019-10-07T13:26:12.365Z] from pkg_resources import load_entry_point [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3095, in <module> [2019-10-07T13:26:12.365Z] @_call_aside [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3079, in _call_aside [2019-10-07T13:26:12.365Z] f(*args, **kwargs) [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3108, in _initialize_master_working_set [2019-10-07T13:26:12.365Z] working_set = WorkingSet._build_master() [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 570, in _build_master [2019-10-07T13:26:12.365Z] ws.require(__requires__) [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 888, in require [2019-10-07T13:26:12.365Z] needed = self.resolve(parse_requirements(requirements)) [2019-10-07T13:26:12.365Z] File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 774, in resolve [2019-10-07T13:26:12.365Z] raise DistributionNotFound(req, requirers) [2019-10-07T13:26:12.365Z] pkg_resources.DistributionNotFound: The 'entrypoints<0.4.0,>=0.3' distribution was not found and is required by flake8 That should be available. https://koji.fedoraproject.org/koji/buildinfo?buildID=1319570 Let me repeat: I do not support EPEL, I don't do EPEL builds. (In reply to Matthias Runge from comment #8) > That should be available. > https://koji.fedoraproject.org/koji/buildinfo?buildID=1319570 > > Let me repeat: I do not support EPEL, I don't do EPEL builds. who's the maintainer of epel builds? moving to tdawson So, it looks like the python dependency generator, that runs during a python package build, didn't, or doesn't happen on EPEL8, as opposed to Rawhide. This is going to require discussion and possibly a long term fix, not for just this package. After Matthias's update to the package, it looks like the only dependency still not manually added is python3-entrypoints. In the mean time, try installing python3-entrypoints and see if it runs properly for you. (In reply to Troy Dawson from comment #11) > In the mean time, try installing python3-entrypoints and see if it runs > properly for you. Yes, once python3-entrypoints is installed it works for me. python-flake8-3.7.7-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. Bodhi closed this bug in a Fedora update, and I think that was a mistake. Re-opening. Troy do you have any link to a EPEL discussion about the Python dependency generator? Python Generators were enabled by default in Fedora 30, on 2019/12/7. (or around that time) https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/5CFYGHOBMSIIUQX5QBCPC4R6NE42G5OE/ There is some discussion about how that will affect EPEL builds here https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/WD6NYJWHRUZHRRTUJEMCYDZ3NXOWVVWH/ I have just verified that EPEL8 builds do *not* get python-rpm-generators installed, and thus do not do automatic python dependency generation. python-rpm-generators is now available for both RHEL8 and RHEL7 (as of RHEL 7.7). I think this is something we should bring up with the EPEL committee, see if we want to enable it by default for at least EPEL8, and possibly EPEL7. Fedora change proposal is here https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault Issue has been proposed to EPEL https://pagure.io/epel/issue/94 Thank you Troy! So, looking at this bug some more, I found that python dependency generator was indeed installed for the epel8 builds. And that it is indeed enabled for RHEL8. python2-devel requires python3-rpm-generators (yep, that's right) platform-python-devel requires python3-rpm-generators and python36-devel requires platform-python-devel. But RHEL8 has an older version than in Fedora. I am investigating further to see why these similar builds didn't get the same dependencies generated. Bug open for RHEL's python-rpm-generators According to the bug, it looks like RHEL8 isn't going to change. After discussion at our last EPEL meeting, it was decided to put this into epel-rpm-macros. After various testing, it looks like we just need to add /usr/lib/rpm/fileattrs/pythondist.attr to epel-rpm-macros. This file doesn't conflict with anything, because it is missing in the RHEL8 python3-rpm-generators. An updated epel-rpm-macros, with this change in it, is available in epel8-playground. After a day or two of testing there, we will move it to the regular epel8. Summary: We're getting close to having this fixed. If I'm interpreting the linked EPEL issues, the neccessary update (https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-92c30fbb1e) has finally hit stable a few days ago. Can we get flake8 rebuilt now to pick up the missing deps ? Will do FEDORA-EPEL-2019-c30b64dc67 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c30b64dc67 python-flake8-3.7.7-6.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c30b64dc67 python-flake8-3.7.7-6.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. |