Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175895
Summary: | Review Request: perl-DBD-XBase - Perl module for reading and writing the dbf files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, tcallawa |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-12-17 01:09:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 175896 |
Description
Jose Pedro Oliveira
2005-12-16 00:13:39 UTC
Basically the package seems OK to me, but I am seeing 2 minor issues with it: 1. The package contains /usr/bin/indexdump. This name ("indexdump") seems too general/generic to me for this specialized tools to have it in /usr/bin. May-be one should consider to split the applications out of the perl-module package into a separate application package. I am not sure. 2. Something it broken with the Makefile. The ./bin/indexdump being generated inside when running "make" contains two "#!/usr/bin/perl -w" shebangs instead of one. Anyway, APPROVED (In reply to comment #1) > Basically the package seems OK to me, but I am seeing 2 minor issues with it: > > 1. The package contains /usr/bin/indexdump. > This name ("indexdump") seems too general/generic to me for this specialized > tools to have it in /usr/bin. May-be one should consider to split the > applications out of the perl-module package into a separate application package. > I am not sure. Maybe renaming it to dbfindexdump in case of conflict? The patch would have to modified the Makefile.PL, some parts of the documentation, and at least a test file. > 2. Something it broken with the Makefile. > The ./bin/indexdump being generated inside when running "make" contains > two "#!/usr/bin/perl -w" shebangs instead of one. Corrected. Patched added to CVS (devel branch - tagged and built as release 2). > Anyway, APPROVED Thanks. PS - Still waiting for the FC-4 CVS branch creation. FC-4 build completed. *** Bug 177272 has been marked as a duplicate of this bug. *** |