Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 176137
Summary: | Review Request: perl-Log-Log4perl - Log4j implementation for Perl | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, steve |
Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Log-Log4perl/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-09 16:52:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 175899 | ||
Bug Blocks: | 163779 |
Description
Jose Pedro Oliveira
2005-12-19 18:07:56 UTC
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Log-Log4perl-1.03-1.src.rpm Changelog * Update to version 1.03 * Using the sourceforge URIs (version 1.03 still hasn't been uploaded into CPAN; it has been released at least three days ago in sourceforge) * Disabled the Log::Dispatch::FileRotate requirement and build requirement (disabled the #171640 dependency) Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, pkgconfigs, or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - no scriptlets - patches look sane Suggestions: - perhaps a comment in the spec file about the issue with Log::Dispatch::FileRotate, and a reference to this bugzilla ticket? - perhaps the rrdtool buildreq could be replaced by perl(RRDs)? Approved. (In reply to comment #2) > Suggestions: > > - perhaps a comment in the spec file about the issue with > Log::Dispatch::FileRotate, and a reference to this bugzilla ticket? Done. > - perhaps the rrdtool buildreq could be replaced by perl(RRDs)? Done. Also added a comment about perl(RRDs) being provided by the rrdtool package (a package outside the perl- namespace). > Approved. Thanks. PS - Also added a comment with the CPAN URL (Log-Log4perl 1.03 appeared today in CPAN). PS2 - Package already built for devel. CVS FC-4 branch pending. Package Change Request ====================== Package Name: perl-Log-Log4perl New Branches: EL-4 EL-5 Owners: steve cvs done. Package Change Request ====================== Package Name: perl-Log-Log4perl New Branches: EL-6 Owners: mmaslano Git done (by process-git-requests). |