Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 176523

Summary:	Review Request: python-json: A JSON reader and writer for Python
Product:	[Fedora] Fedora	Reporter:	Ignacio Vazquez-Abrams <ivazqueznet>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-08 02:48:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 176532

Description Ignacio Vazquez-Abrams 2005-12-24 06:46:01 UTC

Spec Name or Url: http://fedora.ivazquez.net/files/extras/python-json.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/python-json-3_4-1.src.rpm
Description: json.py is an implementation of a JSON (http://json.org) reader and writer in Python.

Comment 1 Jeff Pitman 2005-12-30 04:35:26 UTC

I know upstream uses `_', but wouldn't be more aesthetically pleasing, for rpm,
to use `.'?

Comment 2 Ignacio Vazquez-Abrams 2005-12-31 03:53:46 UTC

Works for me.

http://fedora.ivazquez.net/files/extras/python-json.spec
http://fedora.ivazquez.net/files/extras/python-json-3.4-1.src.rpm

Comment 3 John Mahowald 2006-02-04 15:29:56 UTC

Minor:
Doesn't %ghost *.pyo like the python template does.

Good:

- rpmlint clean

- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

- unit tests pass

APPROVED

Comment 4 Ignacio Vazquez-Abrams 2006-02-08 02:48:51 UTC

Built for FC4 and devel.