Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177168
Summary: | Review Request: perl-UNIVERSAL-isa - Hack around module authors using UNIVERSAL::isa as a function | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-01-31 15:05:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Jose Pedro Oliveira
2006-01-06 20:30:00 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package build OK on FC4 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, pkgconfigs, or subpackages to worry about - not relocatable - no directory ownership or permissions problems - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - scriptlets Needswork: - Source URL http://www.cpan.org/authors/id/id/N/NU/NUFFIN/UNIVERSAL-isa-%{version}.tar.gz doesn't work - suggest http://search.cpan.org/CPAN/authors/id/N/NU/NUFFIN/UNIVERSAL-isa-%{version}.tar.gz instead Fix that and I'll approve the package. Paul, My mistake! There were two "id" directories in the supplied source URL. New SRPM: http://gsd.di.uminho.pt/jpo/software/fedora/perl-UNIVERSAL-isa-0.05-2.src.rpm The specfile link is the same. jpo (In reply to comment #2) > New SRPM: > http://gsd.di.uminho.pt/jpo/software/fedora/perl-UNIVERSAL-isa-0.05-2.src.rpm Approved. Paul, Thanks. Package built for devel. Pending: FC-4 branch creation. |