Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177232
Summary: | Review Request: regionset - reads/sets the region code of DVD drives | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gauret, jpmahowald |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-01 18:52:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Dominik 'Rathann' Mierzejewski
2006-01-08 00:13:27 UTC
Not a review, but: * Don't use Vendor: tag. * Don't do the conditional %clean, just rm -rf $RPM_BUILD_ROOT. You set a sane BuildRoot. * "(see table above)" in %description doesn't make sense, probably from a copy/paste. (just assigning to John and blocking FE-REVIEW) Fixed in http://rpm.greysector.net/extras/regionset-0.1-2.src.rpm (spec address the same as above) Almost there. Still need macros instead of /usr/sbin in %install Dropping FE-NEEDSPONSOR. Tom Callaway offered sponsorship in bug 177235 (and bugzilla change-several-bugs-at-once feature requires me to add/edit something). uhm, bugzilla is broken :( Fixed those macros. http://rpm.greysector.net/extras/regionset.spec http://rpm.greysector.net/extras/regionset-0.1-3.src.rpm *ping* Needs work: - Run rm -rf $RPM_BUILD_ROOT right after %install like the templates - Need smp flags or comments why not Good: + version-release + file permissions good + file ownership good + license (GPL) + sources match http://rpm.greysector.net/extras/regionset.spec http://rpm.greysector.net/extras/regionset-0.1-4.src.rpm Fixed, although there really is no point in using smp flags, because there's only one gcc command ever executed. Well, it doesn't hurt, either. + Follows naming conventions + proper %clean section + proper permissions + macro usage APPROVED Imported and built for devel. Thanks for the review! |