Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 177275

Summary:	Review Request: perl-AnyData: Easy access to data in many formats
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Eric Tanguy <eric.tanguy>
Status:	CLOSED RAWHIDE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-03 21:25:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 177276

Description Tom "spot" Callaway 2006-01-08 18:29:10 UTC

Spec Name or Url: http://www.auroralinux.org/people/spot/review/perl-AnyData.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/perl-AnyData-0.10-1.src.rpm
Description: 

The AnyData modules provide simple and uniform access to data from
many sources -- perl arrays, local files, remote files retrievable via
http or ftp -- and in many formats including flat files (CSV, Fixed
Length, Tab Delimited, etc), standard format files (Web Logs,
Passwd files, etc.),  structured files (XML, HTML Tables) and binary
files with parseable headers (mp3s, jpgs, pngs, etc).

There are two separate modules, each providing a different interface:
AnyData.pm provides a simple tied hash interface and DBD::AnyData
provides a DBI/SQL interface.  You can use either or both depending on
your needs.

This package is a new BuildRequires for perl-Class-DBI-AbstractSearch.

Comment 1 Eric Tanguy 2006-01-25 16:59:11 UTC

Review for release 1:
* RPM name is OK
* Source AnyData-0.10.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-AnyData looks OK
* File list of perl-AnyData looks OK

Needs work:
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)

Comment 2 Paul Howarth 2006-02-02 17:40:46 UTC

(In reply to comment #1)
> Review for release 1:
> * RPM name is OK
> * Source AnyData-0.10.tar.gz is the same as upstream
> * Builds fine in mock
> * rpmlint of perl-AnyData looks OK
> * File list of perl-AnyData looks OK
> 
> Needs work:
> * BuildRequires: perl should not be included
>   (wiki: PackagingGuidelines#Exceptions)
> * Missing SMP flags. If it doesn't build with it, please add a comment
>   (wiki: PackagingGuidelines#parallelmake)

Agreed.

> * The package should contain the text of the license
>   (wiki: PackageReviewGuidelines)

This only applies of the upstream tarball includes the license text, which this
one doesn't.

Comment 3 Tom "spot" Callaway 2006-04-01 05:54:36 UTC

New Spec: http://www.auroralinux.org/people/spot/review/perl-AnyData.spec
New SRPM: http://www.auroralinux.org/people/spot/review/perl-AnyData-0.10-2.src.rpm

Comment 4 Eric Tanguy 2006-04-03 20:24:13 UTC

Review for release 2:
* RPM name is OK
* Source AnyData-0.10.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-AnyData looks OK
* File list of perl-AnyData looks OK
APPROVED