Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 178360
Summary: | Review Request: xmms-adplug | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Linus Walleij <triad> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | j |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-27 17:53:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 177818 | ||
Bug Blocks: | 163779 |
Description
Linus Walleij
2006-01-19 20:02:04 UTC
The package should be named xmms-adplug: http://fedoraproject.org/wiki/PackageNamingGuidelines#head-b624c4531e7a94b9b2c5a2914635e0ad64cda0a6 Fixed it: Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug-1.1-2.src.rpm New package: Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug-1.1-3.src.rpm # Package name is adplug-xmms upstream, but Fedora Extras policies # count it as a subpackage to XMMS so it has been renamed xmms-adplug. # For the source tree to match, adplug-xmms was unpacked, the source # directory renamed xmms-adplug and the result repacked to a .tar.gz # file with this name. For this reason the Source: field below is # not accurate. To download the source, get adplug-xmms from the # same source. Please do not do this. It is best to use the upstream source tarball verbatim whenever possible, and simply override the source dir during %prep. %setup -q -n name-version Please fix this and let me know when you're ready for review. OK it's fixed, sorry for this real stupid mistake :-( Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug-1.1-4.src.rpm The package itself is ready for review, but cannot be reviewed until bug 177818 has been resolved however. Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug-1.1-5.src.rpm Fixes for the problems pointed out by Michael in bug 177865. New release from upstream: Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/xmms-adplug-1.2-1.src.rpm OK the dependant package adplug has been imported and built so this may be reviewed now Warren. Is this package under review? It's assigned but still blocking FE-NEW (and I know Warren's pretty busy these days). I don't think Warren would mind if you hijacked the review for this package Jason... Grabbing this per IRC discussion with Warren. Builds fine in mock and rpmlint is silent. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 293808d1520d9d04c7909d4acb187943 adplug-xmms-1.2.tar.bz2 * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: libadplugxmms.so()(64bit) xmms-adplug = 1.2-1.fc6 = libX11.so.6()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libadplug-2.0.so.0()(64bit) libbinio.so.1()(64bit) libgdk-1.2.so.0()(64bit) libglib-1.2.so.0()(64bit) libgtk-1.2.so.0()(64bit) libxmms.so.1()(64bit) * shared libraries are present, internal to xmms. * package is not relocatable. * owns the directories it creates. _libdir/xmms/Input is provided by xmms-libs, which is a dependency via libxmms.so.1 * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Imported and built fine. Thanks again Jason for saving my packages! |