Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1786958

Summary: Review Request: python-aiomqtt - AsyncIO asynchronous wrapper around paho-mqtt
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-20 01:43:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabian Affolter 2019-12-29 22:38:47 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiomqtt.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiomqtt-0.1.1-1.fc31.src.rpm

Project URL: https://github.com/mossblaser/aiomqtt

Description:
This library implements a minimal Python 3 asyncio wrapper around the MQTT
client in paho-mqtt.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39978687

rpmlint output:
$ rpmlint python-aiomqtt-0.1.1-1.fc31.src.rpm 
python-aiomqtt.src: W: spelling-error Summary(en_US) paho -> pah, pa ho, pa-ho
python-aiomqtt.src: W: spelling-error Summary(en_US) mqtt -> mitt, mutt
python-aiomqtt.src: W: spelling-error %description -l en_US asyncio -> syncopation
python-aiomqtt.src: W: spelling-error %description -l en_US paho -> pah, pa ho, pa-ho
python-aiomqtt.src: W: spelling-error %description -l en_US mqtt -> mitt, mutt
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

$ rpmlint python3-aiomqtt-0.1.1-1.fc31.noarch.rpm 
python3-aiomqtt.noarch: W: spelling-error Summary(en_US) paho -> pah, pa ho, pa-ho
python3-aiomqtt.noarch: W: spelling-error Summary(en_US) mqtt -> mitt, mutt
python3-aiomqtt.noarch: W: spelling-error %description -l en_US asyncio -> syncopation
python3-aiomqtt.noarch: W: spelling-error %description -l en_US paho -> pah, pa ho, pa-ho
python3-aiomqtt.noarch: W: spelling-error %description -l en_US mqtt -> mitt, mutt
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-01-07 18:41:21 UTC

 - Use %{python3_version} or a glob * instead of ?.? because Python 3.10 will break this package otherwise:

%{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info


 - Tests fail:
===================== 1 warnings, 4 error in 1.04 seconds ======================

>               raise child_exception_type(errno_num, err_msg, err_filename)
E               FileNotFoundError: [Errno 2] No such file or directory: 'mosquitto'

   BR mosquitto:

BuildRequires:  mosquitto



 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Gwyn Ciesla 2020-01-09 14:06:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiomqtt

Comment 3 Fabian Affolter 2020-01-10 07:31:24 UTC
Thanks for the review.

Comment 4 Fedora Update System 2020-01-11 01:25:03 UTC
python-aiomqtt-0.1.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ec92538f98

Comment 5 Fedora Update System 2020-01-20 01:43:23 UTC
python-aiomqtt-0.1.1-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.