Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 178903

Summary: Review Request: ikvm
Product: [Fedora] Fedora Reporter: Paul F. Johnson <paul>
Component: Package ReviewAssignee: Michel Alexandre Salim <michel.salim>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-03-09 10:13:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    
Attachments:
Description Flags
Spec diff
none
Complete updated spec file
none
Patch file for ikvm launch scripts none

Description Paul F. Johnson 2006-01-25 11:12:40 UTC
Spec Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm.spec
SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm-0.22-2.src.rpm
Description: This package provides IKVM.NET, an open source Java compatibility layer for Mono, which includes a Virtual Machine, a bytecode compiler, and various class libraries for Java, as well as tools for Java and Mono interoperability.

Comment 1 Paul F. Johnson 2006-01-25 11:18:32 UTC
*** Bug 178902 has been marked as a duplicate of this bug. ***

Comment 2 Paul F. Johnson 2006-01-26 11:05:01 UTC
Spec Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm.spec
SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm-0.22-3.src.rpm

Changelog

Fixed to correctly include IKVM.GNU.Classpath

Comment 3 Rowan Kerr 2006-02-03 23:31:54 UTC
Builds and installs OK. (On fc5t2 upgraded to today's rawhide).


Comment 4 Michel Alexandre Salim 2006-03-05 08:31:24 UTC
The summary seems to refer to MonoDevelop: "A full-featured IDE for Mono and Gtk
sharp" ?

Comment 5 Michel Alexandre Salim 2006-03-06 21:55:17 UTC
Created attachment 125726 [details]
Spec diff

Fixed spec file

Comment 6 Michel Alexandre Salim 2006-03-06 21:55:59 UTC
Created attachment 125727 [details]
Complete updated spec file

Comment 7 Michel Alexandre Salim 2006-03-06 21:56:57 UTC
Created attachment 125728 [details]
Patch file for ikvm launch scripts

Patches script files to use the proper libdir for the architecture

Comment 8 Michel Alexandre Salim 2006-03-06 21:59:40 UTC
I've uploaded some changes to the spec file. Do you know if upstream plans to
release 0.24.0.1 with Unix-style build scripts? Might be worth upgrading if so.

Otherwise, I'll do a full review once you've checked the changes.

- Michel

Comment 9 Paul F. Johnson 2006-03-06 22:06:54 UTC
Thanks. Currently, the plan is to update to 0.24 *sometime* in March, but no
date as yet. I'll commit the patches, rebuild, upload and reply here.

Comment 10 Paul F. Johnson 2006-03-06 22:12:44 UTC
Spec Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm.spec
SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/ikvm-0.22-4.src.rpm

Comment 11 Michel Alexandre Salim 2006-03-08 16:05:41 UTC
Package review:
* rpmlint: clean
* Package name, specfile, license meet guidelines. License files included
* Packaging legible, spec in American English
* Source matches upstream
* Package successfully compiles on x86_64 (Paul's tried i386, I believe?)
* Build dependencies OK
* Package owns its directories
* No duplicate files

Tested on simple Java programs and worked OK.

APPROVED

Comment 12 Paul F. Johnson 2006-03-08 16:07:59 UTC
Tried on both x86 and x86_64 prior to submission

Comment 13 Christian Iseli 2006-04-08 20:52:38 UTC
Please add the package in owners.list