Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 178906

Summary: Review Request: perl-Crypt-SmbHash
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Jose Pedro Oliveira <jose.p.oliveira.oss>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---Flags: kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-01-25 13:57:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 178905    

Description Paul Howarth 2006-01-25 11:21:51 UTC
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-SmbHash/perl-Crypt-SmbHash.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-SmbHash/perl-Crypt-SmbHash-0.12-1.src.rpm
Description:

This module generates Lanman and NT MD4 style password hashes, using perl-only
code for portability. The module aids in the administration of Samba style
systems.

Comment 1 Jose Pedro Oliveira 2006-01-25 12:35:33 UTC
MD5SUMS:
53a9bdce3844e866ee62b7ed2d8b9845  perl-Crypt-SmbHash-0.12-1.src.rpm

a6e3f4d65a89bfcc9ba0c69691e6105b  Crypt-SmbHash-0.12.tar.gz
61922d1c2bfd8b7613b98cdbd3ffc208  perl-Crypt-SmbHash.spec

Sources:
* Crypt-SmbHash-0.12.tar.gz: MD5 digest verified against CPAN copy

Good:
* URL and Source URL ara valid
* License verified (main POD page)
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are OK
* Builds without problems in FC3 and FC5t2
* (Un)installs without problems in FC3 and FC5t2


Needswork:
* since Digest::MD4 is being required it should also be used
  by the test suite (just add it as a build requirement)



Comment 2 Jose Pedro Oliveira 2006-01-25 12:43:06 UTC
Consider the package approved if you also add Digest::MD4 as a BR.


Comment 3 Paul Howarth 2006-01-25 12:46:24 UTC
Spec and SRPM updated with Digest::MD4 as a BR.

Updated SRPM:
http://www.city-fan.org/~paul/extras/perl-Crypt-SmbHash/perl-Crypt-SmbHash-0.12-2.src.rpm


Comment 4 Jose Pedro Oliveira 2006-01-25 13:45:36 UTC
APPROVED.

Comment 5 Paul Howarth 2006-01-25 13:57:58 UTC
Build on target fedora-development-extras succeeded.

Comment 6 Paul Howarth 2007-11-27 10:12:59 UTC
Package Change Request
======================
Package Name: perl-Crypt-SmbHash
New Branches: EL-4 EL-5


Comment 7 Kevin Fenzi 2007-11-27 19:38:36 UTC
cvs done.