Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 179708

Summary: Review Request: dap-freeform_handler - FreeForm data handler for the OPeNDAP Data server
Product: [Fedora] Fedora Reporter: Patrice Dumas <pertusus>
Component: Package ReviewAssignee: Ed Hill <ed>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-02-24 12:19:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 179707    

Description Patrice Dumas 2006-02-02 10:01:14 UTC
SRPM Name or Url: 
Description:  http://www.environnement.ens.fr/perso/dumas/fc-srpms/freeform_handler-3.5.0-1.src.rpm
This is the foreeform data handler for our data server. It reads ASCII,
binary and DB4 files which have been described using FreeForm and returns DAP
responses that are compatible with DAP2 and the dap-server 3.5 software.

Comment 1 Patrice Dumas 2006-02-02 10:08:08 UTC
This bug depends on #179707, but circular dependencies are not allowed.

Comment 2 Ed Hill 2006-02-20 03:47:32 UTC
Heres a review:

38027c71f44da94fddd3024ff2e6d5d3  freeform_handler-3.5.0-1.src.rpm

good:
 + source matches upstream
 + license is acceptable for FE and correctly included
 + very simple and legible spec file
 + dir ownership and permissions look good
 + builds in mock on FC4
 + rpmlint reports no errors or warnings

needswork:
 - license is LGPL not GPL
 - please rename to "dap-freeform_handler" or similar


Comment 4 Ed Hill 2006-02-20 13:55:31 UTC
Both items from comment #2 are fixed so its APPROVED.

Comment 5 Christian Iseli 2006-10-18 13:14:11 UTC
Normalize summary field for easy parsing