Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1800289

Summary: yubihsm-shell: FTBFS in Fedora rawhide/f32
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: yubihsm-shellAssignee: Jakub Jelen <jjelen>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 32CC: g.kihlman, jjelen, msebor, mtasaka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: yubihsm-shell-2.0.2-3.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-16 12:47:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1750908    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
preprocessed source file that reproduces the -Wstringop-overflow warning none

Description Fedora Release Engineering 2020-02-06 20:28:03 UTC
yubihsm-shell failed to build from source in Fedora rawhide/f32

https://koji.fedoraproject.org/koji/taskinfo?taskID=41323160


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
Please fix yubihsm-shell at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
yubihsm-shell will be orphaned. Before branching of Fedora 33,
yubihsm-shell will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2020-02-06 20:28:06 UTC
Created attachment 1661484 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2020-02-06 20:28:10 UTC
Created attachment 1661485 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2020-02-06 20:28:11 UTC
Created attachment 1661486 [details]
state.log

Comment 4 Jakub Jelen 2020-02-10 13:27:42 UTC
Filled https://github.com/Yubico/yubihsm-shell/issues/71 -- The errors are now different than the ones in this bug report, but still not sure whether gcc or this package is wrong.

Comment 5 Ben Cotton 2020-02-11 16:33:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 6 Martin Sebor 2020-02-18 16:48:42 UTC
Can you please attach the preprocessed source file that reproduces the -Wstringop-overflow warning?

Comment 7 Gabriel Kihlman 2020-02-19 13:35:43 UTC
Created attachment 1664042 [details]
preprocessed source file that reproduces the -Wstringop-overflow warning

@Martin: here is the preprocessed source file that reproduces the -Wstringop-overflow warning

build it like (copied from fedpkg local):

cc -O2 -g -pipe -Wall -Werror=format-security -Wno-unused-parameter -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pedantic -Wall -Wextra -Werror -Wno-format-zero-length -Wno-implicit-fallthrough -Wformat -Wformat-security -flto -fstack-protector-all -Wl,-z,relro,-z,now -fPIE -pie -g  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic main.c.i

Comment 8 Martin Sebor 2020-02-19 17:00:42 UTC
Thank you!  I've reduced it to a small test case, confirmed it's a false positive, and opened GCC bug 93829 to get it fixed.

Comment 9 Jakub Jelen 2020-03-05 10:28:30 UTC
Martin, do you have some expectation when fix for this will land in Rawhide so I can rebuild the package? Do you have some downstream bug for this so I do not have to check manually if gcc was already updated?

Comment 10 Martin Sebor 2020-03-09 15:57:45 UTC
Sorry, I don't know on what schedule Jakub Jelinek brings upstream changes in or if there's a way to get notified when he does.

Comment 11 Jakub Jelen 2020-03-16 12:47:21 UTC
Rebuilt successfully now:

https://koji.fedoraproject.org/koji/taskinfo?taskID=42532800

There was still one issue on s390, which I patched and filled upstream:

https://github.com/Yubico/yubihsm-shell/pull/77