Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1804070

Summary:	Warning: The day in the 'when' option in the configuration is malformed.
Product:	[Fedora] Fedora	Reporter:	Vladimir Zhelezov <zhelezov>
Component:	backupninja	Assignee:	Denis Fateyev <denis>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	denis, zhelezov
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	backupninja-1.1.0-5.fc32 backupninja-1.1.0-5.fc30 backupninja-1.1.0-5.fc31 backupninja-1.1.0-5.el8 backupninja-1.1.0-5.el7	Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-25 02:23:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vladimir Zhelezov 2020-02-18 07:38:48 UTC

Description of problem:
Backupninja doesn't parse correctly the name of the day of the week specified with the `when' option in its config files leading to this warning in the log file repeated hourly.

Version-Release number of selected component (if applicable):
backupninja-1.1.0-3.fc31

How reproducible:
Use a value like one of:

when = sunday at 02:00
when = sundays at 02:00

Additional info:

Seems to be fixed about a year ago upstream with this commit
https://0xacab.org/riseuplabs/backupninja/commit/a0f5063e8b31df18b397a91095f33d4efe39f58e

diff --git a/src/backupninja.in b/src/backupninja.in
index 77afbfdfacf856369a38f20522c5e69e56459fe6..d6a1045341d3b41b59bbccc7a00947314b3c0a5b 100755
--- a/src/backupninja.in
+++ b/src/backupninja.in
@@ -226,7 +226,7 @@ function isnow() {
        if [ "$whendayofweek" != "$nowdayofweek" ]; then
            whendayofweek=${whendayofweek%s}
            if [ "$whendayofweek" != "$nowdayofweek" ]; then
-               if [ "$whendayofweek" != "mondays" -a "$whendayofweek" != "tuesdays" -a "$whendayofweek" != "wednesdays" -a "$whendayofweek" != "thursdays" -a "$whendayofweek" != "fridays" -a "$whendayofweek" != "saturdays" -a "$whendayofweek" != "sundays" ]; then
+               if [ "$whendayofweek" != "monday" -a "$whendayofweek" != "tuesday" -a "$whendayofweek" != "wednesday" -a "$whendayofweek" != "thursday" -a "$whendayofweek" != "friday" -a "$whendayofweek" != "saturday" -a "$whendayofweek" != "sunday" ]; then
                    warning "The day in the 'when' option in the configuration is malformed. Please read the README for examples."
                fi
                if [ "$at" != "at" ]; then

Comment 1 Fedora Update System 2020-04-15 21:18:41 UTC

FEDORA-2020-c1bb846422 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c1bb846422

Comment 2 Fedora Update System 2020-04-15 21:18:42 UTC

FEDORA-EPEL-2020-85b0d72bd4 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-85b0d72bd4

Comment 3 Fedora Update System 2020-04-15 21:18:43 UTC

FEDORA-2020-4d9f7e3083 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4d9f7e3083

Comment 4 Fedora Update System 2020-04-15 21:18:46 UTC

FEDORA-2020-23be743fd5 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-23be743fd5

Comment 5 Fedora Update System 2020-04-15 21:18:47 UTC

FEDORA-EPEL-2020-4b95d5a83c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4b95d5a83c

Comment 6 Fedora Update System 2020-04-16 19:28:48 UTC

FEDORA-2020-c1bb846422 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-c1bb846422`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c1bb846422

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-04-16 22:17:37 UTC

FEDORA-2020-4d9f7e3083 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4d9f7e3083`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4d9f7e3083

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-04-16 23:11:00 UTC

FEDORA-EPEL-2020-85b0d72bd4 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-85b0d72bd4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-04-16 23:28:04 UTC

FEDORA-2020-23be743fd5 has been pushed to the Fedora 30 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-23be743fd5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-23be743fd5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-04-16 23:42:28 UTC

FEDORA-EPEL-2020-4b95d5a83c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4b95d5a83c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-04-25 02:23:46 UTC

FEDORA-2020-c1bb846422 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-04-25 02:42:33 UTC

FEDORA-2020-23be743fd5 has been pushed to the Fedora 30 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-04-25 03:01:11 UTC

FEDORA-2020-4d9f7e3083 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-05-01 10:53:56 UTC

FEDORA-EPEL-2020-4b95d5a83c has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2020-05-01 10:57:31 UTC

FEDORA-EPEL-2020-85b0d72bd4 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.