Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1807806

Summary: Incorrect reference to BR: pkgconfig(zlib)
Product: [Fedora] Fedora Reporter: barsnick
Component: heaptrackAssignee: Jan Grulich <jgrulich>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: jgrulich, kde-sig
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: heaptrack-1.1.0-6.fc31 heaptrack-1.1.0-6.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-06 02:23:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description barsnick 2020-02-27 09:54:03 UTC
Description of problem:
The SPEC file incorrectly references a BuildRequires as pkgconfig(zlib), even though the build system doesn't use pkgconfig.

Version-Release number of selected component (if applicable):
1.1.0-5

Additional info:
As far as I can tell, heaptrack's CMake build system doesn't use pkgconfig at all, just classic preprocessing and compile tests (search for headers and libs). Therefore specifiying a BuildRequires using "pkgconfig()" is semantically incorrect, even though it works just fine within Fedora. Correct would be to specify "BuildRequires: zlib-devel" as for the other packages.

Comment 1 Jan Grulich 2020-02-27 10:00:14 UTC
I believe this a correct way how to require a dependency.

See https://fedoraproject.org/wiki/PackagingDrafts/PkgConfigBuildRequires. Using BR: pkgconfig(zlib) will work in future even if the zlib-devel starts providing a different library.

Comment 2 Jan Grulich 2020-02-27 10:06:23 UTC
Reading it again, you are probably correct. I will fix it with the other request you reported.

Comment 3 Fedora Update System 2020-02-27 11:18:28 UTC
FEDORA-2020-936a31cf2d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-936a31cf2d

Comment 4 Fedora Update System 2020-02-27 18:38:10 UTC
heaptrack-1.1.0-6.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-936a31cf2d

Comment 5 Fedora Update System 2020-02-28 01:27:24 UTC
heaptrack-1.1.0-6.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-61f2b8f035

Comment 6 Fedora Update System 2020-03-06 02:23:13 UTC
heaptrack-1.1.0-6.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2020-03-16 20:16:49 UTC
heaptrack-1.1.0-6.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-03-16 20:29:33 UTC
heaptrack-1.1.0-6.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.