Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 181444

Summary:	Review Request: lcov -- process gcov output into nice html pages
Product:	[Fedora] Fedora	Reporter:	Roland McGrath <roland>
Component:	Package Review	Assignee:	Dan Horák <dan>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dan, j
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-03-04 12:04:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Roland McGrath 2006-02-14 06:30:22 UTC

Spec Name or Url: http://people.redhat.com/roland/tmp/lcov.spec
SRPM Name or Url: http://people.redhat.com/roland/tmp/lcov-1.4-1.src.rpm
Description: 

LCOV is an extension of GCOV, a GNU tool which provides information
about what parts of a program are actually executed (i.e. "covered")
while running a particular test case. The extension consists of a set
of PERL scripts which build on the textual GCOV output to implement
HTML output and support for large projects.

Comment 1 Dan Horák 2006-02-15 16:30:31 UTC

only one note to the spec
- empty %build => should be omitted

And as this looks as a uncomplicated package I could do a my first formal
package review.

Comment 2 Dan Horák 2006-02-16 07:55:43 UTC

The file for Source0 at URL
http://ltp.sourceforge.net/coverage/tools/lcov-%{version}.tar.gz doesn't exist, use 
http://dl.sf.net/ltp/lcov-%{version}.tar.gz instead.

Comment 3 Jason Tibbitts 2006-02-18 22:51:40 UTC

Dan, were you going to review this?  It's still unassigned and blocking FE-NEW.
 You should assign it to yourself and make it block FW-REVIEW instead, or let me
know and I'll review it.

Comment 4 Roland McGrath 2006-02-21 01:09:31 UTC

I've put a new version in http://people.redhat.com/roland/tmp/ that addresses
the reviewers' comments and fixes another bug.

Comment 5 Dan Horák 2006-03-04 10:38:01 UTC

Good:

- rpmlint clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package is noarch without a %build section and builds on FC4 (i386)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- works for me

APPROVED

Comment 6 Roland McGrath 2006-03-04 12:04:49 UTC

Built in devel.

Comment 7 Christian Iseli 2006-04-08 20:54:58 UTC

Please add the package in owners.list

Comment 8 Roland McGrath 2006-04-10 03:20:14 UTC

I added it to owners.list; I don't know if any more magic is required.

Comment 9 Christian Iseli 2006-04-10 12:49:19 UTC

Thanks.  It all looks fine now, I think.  No additional magic required :-)

Comment 10 Roland McGrath 2009-08-25 19:36:52 UTC

Package Change Request
======================
Package Name: lcov
New Branches: EL-4 EL-5
Owners: roland

Comment 11 Kevin Fenzi 2009-08-26 22:36:13 UTC

cvs done.