Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 181753
Summary: | Review Request: mm - Shared memory allocation library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jochen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-06 09:52:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Andreas Thienemann
2006-02-16 07:46:48 UTC
Good: + md5sum of source tar file ok. + Local build workes fine. * Build on mock (fedora-devel) workes fine. Bad: - Please use make %{?smp_mlfags} if possible. - inconsitent use of $RPM_BUILD_ROOT and %{buildroot} - Don't put .a file in devel package. - /usr/lib/libmm.so.14.0.20 is not stripped. (In reply to comment #1) > Bad: > - Please use make %{?smp_mlfags} if possible. > - inconsitent use of $RPM_BUILD_ROOT and %{buildroot} > - Don't put .a file in devel package. > - /usr/lib/libmm.so.14.0.20 is not stripped. fixed. In general: Please increase the release count for eatch new relase of your package. You should do this even for the review process. Question: Is it realy inpossible to use %{?_smp_mflags}? Bad: - mm-debuginfo contains no debug information. BTW: Sorry for the typo in comment #1. (In reply to comment #4) > Bad: > - mm-debuginfo contains no debug information. Uhm. I have absolutely no clue about the debuginfo packages. Got any hints about this problem? Of course. the debuginfo package contains the debugging information. This will be created, when you compiled a program with the -g compiler switch. Before the RPM will be created the binaries will be stripped and the debug informations will be stored in seperates files which going to the debuginfo package. When you install a debuginfo package, the content of the package will be installed on /usr/src7debug. Yeah. But what to do in case the debuginfo package contains no debug information? I surely didn't remove them from the package, so I can't put them back in. ;-D Look for something that strips the binaries during build, and get rid of that. "strip", "install -s", and "ld -s" are common culprits. Oh... I see you're running strip yourself in the specfile, so yes, you _did_ remove that stuff from the package. Don't do that, just have redhat-rpm-config installed and let rpmbuild take care of it. Ahrgl. Right. I put a strip call in there. Sorry, forgot about that. Now that I think about it, I did this as otherwise rpmlint would complain about "W: mm unstripped-binary-or-object /usr/lib/libmm.so.14.0.20". I thought just stripping the lib would be enough, but didn't think about the debugpackage. The problem were wrong permissions, which made find-debuginfo.sh not pick up the library. Fixed now & spec updated. When you increase the relase count you should post a link to the new uploaded package. Good: + rpmlint to source rpm is ok. + rpmlint to binary rpms are ok. + mock build worked fine. Bad: - debuginfo package doesn't contains source files for debugging. As far as I can see, you don't use the -g compiler flag. Pless see the following part of my compile run: ./libtool --quiet --mode=compile gcc -c -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexce ptions -m32 -march=i686 -mtune=pentium4 -fasynchronous-unwind-tables mm_global.c ./libtool --quiet --mode=compile gcc -c -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexce ptions -m32 -march=i686 -mtune=pentium4 -fasynchronous-unwind-tables mm_alloc.c ./libtool --quiet --mode=compile gcc -c -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexce Okay. I passed --enable-debug to the %configure macro. Otherwise libtool would remove -g from the CFLAGS. Schtupid. Anyway, updated package is uploaded: Spec Name or Url: http://helena.bawue.de/~ixs/mm/mm.spec SRPM Name or Url: http://helena.bawue.de/~ixs/mm/mm-1.4.0-3.src.rpm Good: + rpmlint of source rpm ok. + local build workes fine. + rpmlint of binaries packages ok. + debuginfo packages ok. + build fine on mock. + local install work fine. + local remove of the packages worked fine. You package is APPROVED !!! |