Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 181979
| Summary: | Review Request: python-geoip - Python bindings for the GeoIP geographical lookup libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Fleming <mfleming+rpm> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-02-21 22:38:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Michael Fleming
2006-02-18 10:13:47 UTC
A clean package, builds fine in mock on i386 and x86_64. However, I don't think the name is proper. By my understanding of the naming guidelines, your package should be python-GeoIP. rpmlint says: W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_city.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_org.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_region.py /usr/bin/python This is the rpm dependency generator picking up a /usr/bin/python dependency from the executable scripts marked %doc. In this case I believe the added dependency is just redundant since python is required anyway and there's no prohibition against executable documentation that I can fine, but if you want to quiet rpmlint, just chmod -x the files. Note also that three of the example files will not work at all with the (free) GeoIP package in Extras. I don't think this is a blocker, but it may generate bug reports. Respin now available :-) Spec Name or Url: http://www.enlartenment.com/extras/python-GeoIP.spec SRPM Name or Url: http://www.enlartenment.com/extras/python-GeoIP-1.2.1-2.src.rpm - Name changed per package naming conventions - Execute bit removed from test*.py to keep RPM's dep generator from doing Bad Things. Cool. rpmlint is now silent and the name neets the guidelines. The specfile is taken from the Python template and is clean. There are no installed (non-doc) .py or .pyc files, so no .pyo files to ghost. The source file matches upstream. The license is appropriate, matches the spec and is included as %doc. Absolutely minor nitpick: your Description: needs a period. Somewhat less minor nitpick: Requires: GeoIP is redundant. RPM picks up the libGeoIP.so.1 requirement automatically. Sorry I didn't catch those at first glance. Fix them up and it's good to go. Spec Name or Url: http://www.enlartenment.com/extras/python-GeoIP.spec SRPM Name or Url: http://www.enlartenment.com/extras/python-GeoIP-1.2.1-3.src.rpm Recommendations noted and updates made. Looks great. Approved. Imported and a devel branch build requested. |