Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 181993
Summary: | Review Request: charis-fonts - Charis SIL fonts | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Roozbeh Pournader <roozbeh> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-19 17:31:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 481476 |
Description
Roozbeh Pournader
2006-02-18 15:57:53 UTC
This is a nice, clean package; you should consider submitting a specfile template for fonts. Upstream's download system is annoying, but that's not your fault and you at least provided instructions for getting the source. rpmlint says: W: charis-fonts invalid-license SIL Open Font License W: charis-fonts wrong-file-end-of-line-encoding /usr/share/doc/charis-fonts-4.0.02/CharisSIL4FontDocumentation.pdf The license is acceptable; it's probably worth opening a bug against rpmlint to get it added. The second warning is just rpmlint being dumb; there's no point in paying attention to line endings in a PDF file. Anyway: rpmlint output is fine. The package meets the naming and packaging guidelines. The specfile is properly named and follows rather exactly that of a previously accepted package. The source file matches upstream. The license is appropriate and included as %doc. Approved. Thanks a lot for the review. Imported and built. Just a reminder that fonts.cache-1 file ghosting is not needed for FC5. See http://www.redhat.com/archives/fedora-extras-list/2006-January/msg00918.html OTOH, ghosting fonts.cache-1 doesn't hurt anything either, and maintains compability with older releases. |