Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1825461

Summary: home-assistant-cli-0.9.0-1 fails to build: test_wsapimethod_completion fails
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: home-assistant-cliAssignee: Fabian Affolter <mail>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mail, mhroncok, mplch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-09 11:10:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803234, 1785415    

Description Miro Hrončok 2020-04-18 09:37:39 UTC
home-assistant-cli-0.9.0-1 fails to build with Python 3.8 and with 3.9.0a5:

=================================== FAILURES ===================================
_________________________ test_wsapimethod_completion __________________________

default_services = [{'domain': 'homeassistant', 'services': {'check_config': {'description': 'Check the Home Assistant configuration file...example': 'red'}, 'color_temp': {'description': 'Color temperature for the light in mireds.', 'example': 250}, ...}}}}]

    def test_wsapimethod_completion(default_services) -> None:
        """Test completion for raw ws API methods."""
        cfg = Configuration()
    
        result = autocompletion.wsapi_methods(
            cfg, ["raw", "get"], "config/device_registry/l"
        )
>       assert len(result) == 1
E       assert 0 == 1
E         -0
E         +1

tests/test_raw.py:73: AssertionError
=============================== warnings summary ===============================
/usr/lib64/python3.8/site-packages/aiohttp/helpers.py:107
  /usr/lib64/python3.8/site-packages/aiohttp/helpers.py:107: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def noop(*args, **kwargs):  # type: ignore

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 1 failed, 62 passed, 1 deselected, 1 warnings in 1.70 seconds =========


This blocks the Python 3.9 rebuild:

For the build logs with Python 3.9, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01337211-home-assistant-cli/

For all our attempts to build home-assistant-cli with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/home-assistant-cli/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-04-18 09:41:20 UTC
Fabian, this is not the first time I see you push unbuildable changes to your packages. I am not familiar with your workflow, but I would really appreciate if you could test your changes before you push them and maintain the work in progress work locally or in a pull request. There might be several reasons other packagers need to rebuild yours (such as Python upgrades like here) and this creates unnecessary noise and friction. Thank you.