Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1825462

Summary: python-repoze-who (2.3-1 and 2.1-23) fails to build in rawhide (likely zope.interface related)
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-repoze-whoAssignee: Clement Verna <clems.verna>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: clems.verna, cstratak, lbalhar, lewk, mhroncok, mplch, ondrejj
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-10 10:19:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803234, 1785415    

Description Miro Hrončok 2020-04-18 09:49:53 UTC
python-repoze-who (2.3-1 and 2.1-23) fails to build in rawhide:

======================================================================
ERROR: test_brokenimpl (repoze.who.tests.test_api.TestMakeRegistries)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/repoze.who-2.3/repoze/who/tests/test_api.py", line 107, in test_brokenimpl
    self.assertRaises(ValueError, self._callFUT,
  File "/usr/lib/python3.8/unittest/case.py", line 816, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/usr/lib/python3.8/unittest/case.py", line 202, in handle
    callable_obj(*args, **kwargs)
  File "/builddir/build/BUILD/repoze.who-2.3/repoze/who/tests/test_api.py", line 98, in _callFUT
    return make_registries(identifiers, authenticators,
  File "/builddir/build/BUILD/repoze.who-2.3/repoze/who/api.py", line 72, in make_registries
    verify(value, iface)
  File "/builddir/build/BUILD/repoze.who-2.3/repoze/who/api.py", line 57, in verify
    verifyObject(iface, plugin, tentative=True)
  File "/usr/lib/python3.8/site-packages/zope/interface/verify.py", line 172, in verifyObject
    return _verify(iface, candidate, tentative, vtype='o')
  File "/usr/lib/python3.8/site-packages/zope/interface/verify.py", line 92, in _verify
    raise MultipleInvalid(iface, candidate, excs)
zope.interface.exceptions.MultipleInvalid: The object <object object at 0xf722e4d0> has failed to implement interface <InterfaceClass repoze.who.interfaces.IIdentifier>:
    The repoze.who.interfaces.IIdentifier.identify(environ) attribute was not provided
    The repoze.who.interfaces.IIdentifier.remember(environ, identity) attribute was not provided
    The repoze.who.interfaces.IIdentifier.forget(environ, identity) attribute was not provided
----------------------------------------------------------------------
Ran 301 tests in 0.069s
FAILED (errors=1)

I strongly suspect this started happening after python-zope-interface was updated to 5.1.0 (bz1822171). Unfortunately, python-repoze-who was not tracked in Koschei, so I cannot tell for sure.


This blocks the test rebuild with Python 3.9.0a5.

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01339462-python-repoze-who/

For all our attempts to build python-repoze-who with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-repoze-who/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Jan ONDREJ 2020-04-18 13:47:51 UTC
Looks like it's really a zope-interface-5 problem. Tested on Fedora 31, updated zope-interface and fails.

Reported upstream:
https://github.com/repoze/repoze.who/issues/32

Comment 2 Miro Hrončok 2020-05-09 11:11:37 UTC
Clement?

Comment 3 Jan ONDREJ 2020-05-09 17:10:02 UTC
Miro, I added a patch upstream, but not sure if this is a real solution.
What do you think? Should I apply it in Fedora?
Clement? Any suggestions?

Comment 4 Miro Hrončok 2020-05-09 20:54:29 UTC
I'd say yes.

Comment 5 Jan ONDREJ 2020-05-10 10:19:30 UTC
Build done, not sure if fully functional:

https://koji.fedoraproject.org/koji/taskinfo?taskID=44304161